Feature/merge master #1371
Merged
Feature/merge master #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beginning of fix add this to worksheet.py
(failing) for combine func new args
This reverts commit be127bd.
…-use-it remove `use_index` and references to it in `get_records`
now, if a user does not specify client_factory, they will not get a warning
…depends-on-kwarg make deprecation warning dependent on if kwarg is used for client_factory
expected_headers test
expected_headers not set
fix 1352 expected headers broken
This reverts commit 0e698de.
(cherry picked from commit 67141a1)
…ducing-incorrect-result-when-used-on-a-non-default-cell-range fix `combine_merged_cells` when using from a range that doesn't start at `A1`
change `worksheet.update` migration guide
This reverts commit 3fc6847.
This reverts commit cba30e4.
This reverts commit 2a19101.
This reverts commit 25287e5.
…a-large-number-of-empty-rows-after-the-end-of-the-data 1363 get all records retrieves a large number of empty rows after the end of the data
Skip CVE directly related to wrong pip version, we only use it a tool for the CI to run the package we don't actually use it in production, we don't handle nor manage pip versions
alifeee
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
so far I didn't have to change the tests to make it pass
if you didn't have to change any tests then... all is good!... well... it is our fault if things went wrong for writing bad tests...!
but yes. great work with this! merges are busy things :)
merge time!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to merge master in release/6.0.0
I might be wrong on some of the conflicts I solved with the
get,get_valuesmerge, with thecombined_merge_cellsand all tests related to it.so far I didn't have to change the tests to make it pass (except the method signature that changed for
Worksheet.update().closes #1356