Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme examples #1431

Merged
merged 2 commits into from
Mar 14, 2024
Merged

update readme examples #1431

merged 2 commits into from
Mar 14, 2024

Conversation

alifeee
Copy link
Collaborator

@alifeee alifeee commented Mar 8, 2024

closes #1410

The examples in the readme were wrong, and did not work

I think we should go through and test them to see if they work. I will do this soon if you do not. :)

@alifeee alifeee added the Docs label Mar 8, 2024
@alifeee alifeee added this to the 6.1.0 milestone Mar 8, 2024
@lavigne958
Copy link
Collaborator

closes #1410

The examples in the readme were wrong, and did not work

I think we should go through and test them to see if they work. I will do this soon if you do not. :)

I will test them now

@lavigne958
Copy link
Collaborator

The below example don't work either:

  • worksheet.update('B1', 'Bingo!')

    we should swap the value and the range too, and put the value into a matrix [[".."]]

apart from that the rest works fine 👍

@alifeee alifeee requested a review from lavigne958 March 13, 2024 09:43
@alifeee
Copy link
Collaborator Author

alifeee commented Mar 13, 2024

re: #1410 (comment), I may have got the examples here the wrong way round. not sure. have to test.

@lavigne958
Copy link
Collaborator

re: #1410 (comment), I may have got the examples here the wrong way round. not sure. have to test.

looks good, I checked it's the right way around now.

@alifeee alifeee merged commit 6e864b8 into master Mar 14, 2024
10 checks passed
@alifeee alifeee deleted the fix/readme branch March 14, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update examples of gspread usage /Readme.md
2 participants