Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes for Worksheet.update argument ordering & single cell updating (i.e. now Worksheet.update_acell) #1449

Merged
merged 4 commits into from
Apr 5, 2024

Conversation

alexmalins
Copy link
Contributor

Fixes similar to #1431 for docs, a docstring and a test.

  • Worksheet.update default argument ordering is now Worksheet.update(<values>, <range name>, ...
  • Single cell updating uses the Worksheet.update_acell method now

@alifeee
Copy link
Collaborator

alifeee commented Apr 4, 2024

hey! thanks for this change !! :)

it is very helpful. I am not sure of the best way of keeping the code and the docs in sync 🤔

I will let @lavigne958 merge :)

@alifeee alifeee requested a review from lavigne958 April 4, 2024 19:22
@lavigne958
Copy link
Collaborator

hey! thanks for this change !! :)

it is very helpful. I am not sure of the best way of keeping the code and the docs in sync 🤔

there isn't in small projects like ours 😞 we must think about updating it every time we change something.

I will let @lavigne958 merge :)
will do !

@lavigne958 lavigne958 merged commit 800654b into burnash:master Apr 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants