Add-501-error-code-[NOT_IMPLEMENTED]-main (#4) #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present we are throwing 404 BAD REQUEST code when user is sending valid input but NEF /CRISP are not process the same For E.g. (External ID , MSISDN , IPV4 and IPV6) are valid UE inputs for Qod-API, but NEF can process only (MSISDN and IPV6 ). in such case we should throw 501 code (NOT IMPLEMENTED) So we are proposing 501 error code with this changes/commmit
Refer to the issue (“Will fix camaraproject#81”).
ravindrapalaskar17
requested review from
hdamker and
shilpa-padgaonkar
as code owners
…ode-501-main Draft/implement error code 501 main
|
Since this feature will be used in 0.9.0 I suggest to set the version to 0.9.0 and the target branch to camaraproject:dev-v0.9.0 |
|
@ilya-smirnov-berlin thanks for clarification. As the camaraproject/WorkingGroups#123 is currently we will need the PR after our fix release against main. There will be no longer a dev branch, latest code will be in main. Order of PRs will be coordinated in our sub project calls. For now I will close the PR ... to be reopen after the 0.8.1 release. |
|
I have just submitted a new PR #104 reformatting errors according to the guidelines. We should review and merge the other one first and then align this one to the new format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the issue (“Will fix #81”).