Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FERC 714: transform of hourly demand table (dbf +xbrl) #3842

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

cmgosnell
Copy link
Member

@cmgosnell cmgosnell commented Sep 12, 2024

Overview

Closes #3838. There is a tasklist in the issue!

What problem does this address?
most of the work here has been in cleaning the date formats 🙄

  • datetimes omigosh....
    • 🟢 convert_dates_to_zero_offset_hours_xbrl hours being 01-24 or 01-00 (of next day.. probably I put in some emails to ferc about this)
    • 🟢 convert_dates_to_zero_seconds: some last record of the days being last second of the day (T23:59)
    • GAPS. There are 41 gaps in the timeseries
    • there are lots of overlapping timestamps rn
  • ...

What did you change?

Testing

How did you make sure this worked? How can a reviewer verify this?

To-do list

@cmgosnell cmgosnell self-assigned this Sep 12, 2024
@cmgosnell cmgosnell added the ferc714 Anything having to do with FERC Form 714 label Sep 13, 2024
@aesharpe aesharpe added the data-update When fresh data is integrated into PUDL from quarterly or annual updates label Sep 16, 2024
@aesharpe
Copy link
Member

Just a lil lonely comment because it's not part of the code you edited therefore I can't comment directly on the line...

The doc strings for the OFFSET_CODES dictionary seems like it has a copy and paste error in it?

Copy link
Member

@aesharpe aesharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! I found it really easy to go through all the functions and understand what was happening to the table. Most of my comments are non-blocking. Love that all of the functions are bite-sized! :)

src/pudl/transform/ferc714.py Outdated Show resolved Hide resolved
src/pudl/transform/ferc714.py Show resolved Hide resolved
src/pudl/transform/ferc714.py Outdated Show resolved Hide resolved
src/pudl/transform/ferc714.py Outdated Show resolved Hide resolved
src/pudl/transform/ferc714.py Outdated Show resolved Hide resolved
src/pudl/transform/ferc714.py Outdated Show resolved Hide resolved
@aesharpe
Copy link
Member

oh also, @cmgosnell reminder to add some color to the metadata/resources/ferc714.py module about the out_ferc714__hourly_planning_area_demand table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-update When fresh data is integrated into PUDL from quarterly or annual updates ferc714 Anything having to do with FERC Form 714
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

Write transform function to clean and normalize FERC 714 XBRL hourly historic load table
3 participants