-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FERC 714: transform of hourly demand table (dbf +xbrl) #3842
base: main
Are you sure you want to change the base?
Conversation
Just a lil lonely comment because it's not part of the code you edited therefore I can't comment directly on the line... The doc strings for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! I found it really easy to go through all the functions and understand what was happening to the table. Most of my comments are non-blocking. Love that all of the functions are bite-sized! :)
…osing all the report_dates plus lots of documentation
* Add respondent ID csv * Add notes columns to CSV
oh also, @cmgosnell reminder to add some color to the |
Overview
Closes #3838. There is a tasklist in the issue!
What problem does this address?
most of the work here has been in cleaning the date formats 🙄
convert_dates_to_zero_offset_hours_xbrl
hours being 01-24 or 01-00 (of next day.. probably I put in some emails to ferc about this)convert_dates_to_zero_seconds
: some last record of the days being last second of the day (T23:59)What did you change?
Testing
How did you make sure this worked? How can a reviewer verify this?
To-do list