log conflicting module options with -d (and other cleanup) #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: If a module is loaded with a conflicting option, then the option is silently ignored, which could lead to confusion in some cases. Log conflicting module options in debug mode (-d). Co-authored-by: Erik Jacobson <erik.jacobson@hpe.com>
Problem: The -d option now enables the display of module loading errors, but this is undocumented. Add text to pdsh.1 and pdcp.1 describing this new feature.
Problem: There's a surfeit of trailing whitespace in the pdsh codebase. Remove trailing whitespace in all .c and .h files.
Problem: Modern compilers warn of possible truncation in calls to strncpy(3) in the pdsh codebase. Fix the warnings in hostlist.c and wcoll.c by reducing the size to copy by one character.
|
Thanks! I forgot mergify is configured here, so I'll see if MWP works. |
grondo
added
the
merge-when-passing
|
@Mergifyio refresh |
✅ Pull request refreshed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts @erikja's proposal in #142, but only emits the messages with the
-doption.The manpages are also updated with an expanded description of the
-doption.Some cleanup is tacked on as well - suppressing some warnings and also removing all the annoying trailing whitespace in the codebase.