Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log conflicting module options with -d (and other cleanup) #154

Merged
merged 4 commits into from
Dec 19, 2023
Merged

log conflicting module options with -d (and other cleanup) #154

merged 4 commits into from
Dec 19, 2023

Commits on Dec 19, 2023

  1. pdsh: log conflicting module options with debug (-d) 

    Problem: If a module is loaded with a conflicting option, then the
option is silently ignored, which could lead to confusion in some cases.

Log conflicting module options in debug mode (-d).

Co-authored-by: Erik Jacobson <erik.jacobson@hpe.com>
    @grondo @erikja
    grondo and erikja committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    d9859b6 View commit details
    Browse the repository at this point in the history

  2. doc: update description of -d option 

    Problem: The -d option now enables the display of module loading
errors, but this is undocumented.

Add text to pdsh.1 and pdcp.1 describing this new feature.
    @grondo
    grondo committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    e3444fe View commit details
    Browse the repository at this point in the history

  3. cleanup: remove trailing whitespace 

    Problem: There's a surfeit of trailing whitespace in the pdsh codebase.

Remove trailing whitespace in all .c and .h files.
    @grondo
    grondo committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    f2d85e9 View commit details
    Browse the repository at this point in the history

  4. fix truncation warnings for strncpy(3) 

    Problem: Modern compilers warn of possible truncation in calls to
strncpy(3) in the pdsh codebase.

Fix the warnings in hostlist.c and wcoll.c by reducing the size to
copy by one character.
    @grondo
    grondo committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    38eda25 View commit details
    Browse the repository at this point in the history