-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test file for DataFormats/L1ScoutingRawData #1
Conversation
A new Pull Request was created by @Mmiglio (Matteo Migliorini) for branch main. @smorovic, @iarspider, @smuzaffar, @emeschi, @aandvalenzuela, @cmsbuild can you please review it and eventually sign? Thanks. |
cms-bot internal usage |
please test |
+daq |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a22f5/36616/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
+externals
By the way, why not add the cmssw test now? |
This pull request is fully signed and it will be integrated in one of the next main IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
Hi @cms-sw/orp-l2, is there anything missing for this PR to be merged? |
This just contain a new data file, so I am merging it. |
@Mmiglio , note that cms-sw/opr-l2 is not a valid team for this organization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here, please include the class version in the file name, i.e. rename to testSDSRawDataCollection_v3_CMSSW_13_3_0_pre5.root
.
Add initial data files that will be used in a unit test of the L1 Scouting raw data formats. These will be read by future releases to verify backward compatibility.
This is related to cms-sw/cmssw#43467. I will open a new PR with improved unit tests for data format.