Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added class version to the file name #2

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

Mmiglio
Copy link

@Mmiglio Mmiglio commented Jan 19, 2024

Renamed test file to include class version, as requested in this comment #1 (comment).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Mmiglio (Matteo Migliorini) for branch main.

@iarspider, @aandvalenzuela, @smuzaffar, @emeschi, @cmsbuild, @smorovic can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 19, 2024

cms-bot internal usage

@smorovic
Copy link

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c16c54/36958/summary.html
COMMIT: b594f4f
CMSSW: CMSSW_14_0_X_2024-01-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/DataFormats-L1ScoutingRawData/2/36958/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smorovic
Copy link

+daq

@smuzaffar
Copy link
Contributor

+externals

@Mmiglio , is there any cmssw PR which uses this new (renamed) file?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next main IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@Mmiglio
Copy link
Author

Mmiglio commented Feb 15, 2024

Hi @smuzaffar, shall I proceed with the PR using this files or wait for this PR to be merged before opening one in CMSSW?

@smuzaffar
Copy link
Contributor

@Mmiglio , please proceed with the cmssw PR which uses this file. CMSSW PR can be tested together with this PR

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @rappoccio, @antoniovilela: This PR was tested with cms-sw/cmssw#43984, please check if they should be merged together

@rappoccio
Copy link

+1

@cmsbuild cmsbuild merged commit 4ac3e1e into cms-data:main Feb 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants