-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added class version to the file name #2
Conversation
A new Pull Request was created by @Mmiglio (Matteo Migliorini) for branch main. @iarspider, @aandvalenzuela, @smuzaffar, @emeschi, @cmsbuild, @smorovic can you please review it and eventually sign? Thanks. |
cms-bot internal usage |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c16c54/36958/summary.html Comparison SummarySummary:
|
+daq |
+externals @Mmiglio , is there any cmssw PR which uses this new (renamed) file? |
This pull request is fully signed and it will be integrated in one of the next main IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
Hi @smuzaffar, shall I proceed with the PR using this files or wait for this PR to be merged before opening one in CMSSW? |
@Mmiglio , please proceed with the cmssw PR which uses this file. CMSSW PR can be tested together with this PR |
REMINDER @sextonkennedy, @rappoccio, @antoniovilela: This PR was tested with cms-sw/cmssw#43984, please check if they should be merged together |
+1 |
Renamed test file to include class version, as requested in this comment #1 (comment).