Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ROCm SMI library #8848

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Nov 30, 2023

Add the ROCm SMI library (librocm_smi64.so) to the ROCm tools.

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 30, 2023

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_14_0_X/master.

@iarspider, @smuzaffar, @aandvalenzuela can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-baaa82/36204/summary.html
COMMIT: 9e0165b
CMSSW: CMSSW_14_0_X_2023-11-30-0800/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8848/36204/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor

+externals

@fwyzard , is it ready to go in or should we merge it with cms-sw/cmssw#43451

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2023

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 1, 2023

@smuzaffar, yes, this can go in by itself.

Then cms-sw/cmssw#43451 should be merged once this is available.

@smuzaffar smuzaffar merged commit 3acaeff into cms-sw:IB/CMSSW_14_0_X/master Dec 1, 2023
9 checks passed
@fwyzard fwyzard deleted the IB/CMSSW_14_0_X/master_add_rocm_smi64 branch December 1, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants