Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ROCm tools #43451

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Update ROCm tools #43451

merged 4 commits into from
Dec 1, 2023

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Nov 30, 2023

PR description:

Fix the ROCmService and rocmComputeCapabilities tools.

Add a function to check the status of ROCm SMI functions, rsmiCheck(...).

PR validation:

Tested with ROCm 5.2.x and 5.7.x.
Unit tests pass.

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 30, 2023

please test with cms-sw/cmsdist#8848

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43451/38000

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

  • HeterogeneousCore/ROCmServices (heterogeneous)
  • HeterogeneousCore/ROCmUtilities (heterogeneous)

@fwyzard, @makortel can you please review it and eventually sign? Thanks.
@missirol, @rovere, @makortel this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 30, 2023

please test with cms-sw/cmsdist#8848

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43451/38001

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #43451 was updated. @fwyzard, @makortel can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 30, 2023

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9096c6/36208/summary.html
COMMIT: 498f364
CMSSW: CMSSW_14_0_X_2023-11-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43451/36208/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f190603 into cms-sw:master Dec 1, 2023
11 checks passed
@fwyzard fwyzard deleted the update_ROCm_tools branch January 30, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants