Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to take DCS Status from software FED, when SCAL is not available #29198

Merged
merged 5 commits into from
Mar 30, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 13, 2020

PR description:

In case the DCS status from SCAL is not available, fall back to DCSRecord data provided by the software FED n. 1022. The logic is modified in two classes: SiStripDCSStatus and DetStatus.
Both classes are used to select events in different ALCARECO workflows, while SiStripDCSStatus
is also used to filter events in several Tracker and Tracking DQM modules.
No differences are expected in Run1 and Run2 workflows. For Run3 data the ALCARECO selectors now work correctly.

PR validation:

Tested with runTheMatrix.py -l 1001.0,138.1 and checked that in runs with SCAL there are no differences, while with recent MWGR 2020 cosmic data the events are filtered correctly.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport, but a backport will be proposed in 11.0.X to be used for the next MWGR.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29198/14183

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CalibTracker/SiStripCommon
DPGAnalysis/Skims

@pgunnell, @chayanit, @zhenhu, @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @mverzett, @mmusich this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 13, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5174/console Started: 2020/03/13 23:13

@cmsbuild
Copy link
Contributor

+1
Tested at: b94a0e2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37ce04/5174/summary.html
CMSSW: CMSSW_11_1_X_2020-03-13-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37ce04/5174/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680593
  • DQMHistoTests: Total failures: 32963
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2647311
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -997.953 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -12.689 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -15.243 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -11.698 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -500.872 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -457.451 KiB SiStrip/MechanicalView
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@mmusich
Copy link
Contributor Author

mmusich commented Mar 14, 2020

DQMHistoTests: Total failures: 32963

The simulation workflows are not being treated correctly. I'll fix in the next commit.

@christopheralanwest
Copy link
Contributor

test parameters
workflow = 138.1

@christopheralanwest
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 17, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 5f46131
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37ce04/5221/summary.html
CMSSW: CMSSW_11_1_X_2020-03-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37ce04/5221/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-37ce04/138.1_RunCosmics2020+RunCosmics2020+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680593
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2680272
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@mmusich
Copy link
Contributor Author

mmusich commented Mar 26, 2020

ping @pgunnell, @chayanit, @christopheralanwest, @tocheng, @tlampen, @pohsun

This PR is eventually needed for the Run3 data-taking and a backport is in order for the next MGWR (whenever that'll be). Can you please take a look?

@chayanit
Copy link

+1

@tocheng
Copy link
Contributor

tocheng commented Mar 30, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants