Modernize DQM/BeamMonitor/plugins/TKStatus plugin

[francescobrivio]

PR description:

In the same spirit of #29198, #35782 and #37084, this PR modernizes the DQM/BeamMonitor/plugins/TKStatus plugin to use DCSRecord token in case the DCS information from SCAL is not available (i.e. from Run3 onwards).
Changes:

• unified TKStatus.cc and TKStatus.h
• added DCSRecord consumption (and a logic to choose between it and DCSstatus)
• added process.onlineMetaDataDigis unpacker in the only DQM client running in production that uses TkStatus
• added process.onlineMetaDataDigis unpacker to a bunch of configs under DQM/BeamMonitor/test that were importing and using TkStatus

PR validation:

Code compiles.
Tested by running on run 348490:

cmsRun DQM/Integration/python/clients/beam_dqm_sourceclient-live_cfg.py unitTest=True dataset='/ExpressCosmics/Commissioning2022-Express-v1/FEVT' runNumber=348490

which has only Pixels ON.
And by running on run 348587:

cmsRun DQM/Integration/python/clients/beam_dqm_sourceclient-live_cfg.py unitTest=True dataset='/ExpressCosmics/Commissioning2022-Express-v1/FEVT' runNumber=348587

which has both Pixel and Strips ON.

Backport

A backport to 12_3_X is provided in #37223
A backport to 12_2_X is provided in #37224

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37214/28814

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

• DQM/BeamMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@francescobrivio
you are missing the onlineMetaDataDigis unpacker from the executed paths (see #30677).
The reason why you don't have them for the DQM test is because - in order to mimic the real data-taking scenario in which you don't run over FEVT but rather on un-reconstructed streamer files - I drop the non-FEDRawData branches here:

cmssw/DQM/Integration/python/config/unittestinputsource_cfi.py

Lines 119 to 124 in 523b360

	inputCommands = cms.untracked.vstring(
	'drop *',
	'keep FEDRawDataCollection_rawDataCollector_*_*',
	'keep GlobalObjectMapRecord_hltGtStage2ObjectMap_*_*',
	'keep edmTriggerResults_TriggerResults_*_*'
	),

precisely to catch this sort of issues upstream and not when the client is run online at P5 :)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37214/28825

• This PR adds an extra 32KB to repository

[cmsbuild]

Pull request #37214 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

[francescobrivio]

@cmsbuild please test

[francescobrivio]

@cms-sw/dqm-l2 do we also need a 12_2 backport?
In principle beamspot clients are not important for cosmics, but if you want to test it in the playback system just let me know and I can open a 12_2 backport.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7665a/23067/summary.html
COMMIT: fab8b2b
CMSSW: CMSSW_12_4_X_2022-03-11-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37214/23067/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695161
• DQMHistoTests: Total failures: 16
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3695122
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[francescobrivio]

@cms-sw/dqm-l2 do we also need a 12_2 backport? In principle beamspot clients are not important for cosmics, but if you want to test it in the playback system just let me know and I can open a 12_2 backport.

I opened a 12_2_X backport in #37224

[jfernan2]

+1
Tested backport to 12_2_X #37224 successfully in Online DQM at P5 (no crashes).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1