-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12_2_X] Modernize DQM/BeamMonitor/plugins/TKStatus
plugin
#37224
[12_2_X] Modernize DQM/BeamMonitor/plugins/TKStatus
plugin
#37224
Conversation
A new Pull Request was created by @francescobrivio for CMSSW_12_2_X. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
backport of #37214 |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-412d67/23069/summary.html Comparison SummarySummary:
|
Since this PR is potentially affecting Online DQM, I'd like to test it at P5 before signing |
thanks @jfernan2 I agree! |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Backport of #37214 to 12_2_X
Modernize the
DQM/BeamMonitor/plugins/TKStatus
plugin to useDCSRecord
token in case the DCS information from SCAL is not available (i.e. from Run3 onwards).PR validation:
Code compiles + see tests in master PR.
@cms-sw/dqm-l2 This backport should be tested online at P5.
Backport:
Backport of #37214