Enable CaloParticles in the barrel for Phase2 and introduce LC associations #43248

brusale · 2023-11-10T15:48:34Z

PR description:

This PR enables the creation of CaloParticles in both ECAL and HCAL for Phase2. In addition, LayerCluster to CaloParticle and LayerCluster to SimCluster associations (described here and used in SimCalorimetry/HGCalAssociatorProducers) are introduced for the barrel region. Also, namespace hgcal has been changed into namespace ticl.

PR validation:

Tested on workflows 24896.0 and 24900.0.

@felicepantaleo @rovere @thomreis @valsdav @bmarzocc @hatakeyamak

cmsbuild · 2023-11-10T15:55:12Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43248/37615

This PR adds an extra 100KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): move dictionaries next to typedefs for TrackingParticle associations #37507

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43248/37615/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43248/37615/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2023-11-10T16:06:59Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43248/37616

This PR adds an extra 204KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): move dictionaries next to typedefs for TrackingParticle associations #37507

cmsbuild · 2023-11-10T16:07:27Z

A new Pull Request was created by @brusale (Alessandro Brusamolino) for master.

It involves the following packages:

SimCalorimetry/HGCalAssociatorProducers (upgrade, simulation)
SimDataFormats/Associations (simulation)
SimGeneral/MixingModule (simulation)
Validation/HGCalValidation (dqm)

@AdrianoDee, @mdhildreth, @cmsbuild, @syuvivida, @rvenditti, @antoniovagnerini, @tjavaid, @nothingface0, @civanch, @srimanob can you please review it and eventually sign? Thanks.
@ebrondol, @felicepantaleo, @fabiocos, @bsunanda, @vandreev11, @pfs, @rovere, @sameasy, @slomeo, @missirol, @makortel, @lgray, @apsallid, @lecriste, @hatakeyamak, @sethzenz, @cseez, @youyingli this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

felicepantaleo · 2023-11-11T10:50:30Z

@cmsbuild please test

cmsbuild · 2023-11-11T11:13:55Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c54897/35751/summary.html
COMMIT: 2019177
CMSSW: CMSSW_14_0_X_2023-11-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43248/35751/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-10-2300/src/RecoHGCal/TICL/plugins/TrackstersMergeProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-10-2300/src/RecoHGCal/TICL/plugins/TrackstersMergeProducerV3.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-10-2300/src/RecoHGCal/TICL/plugins/TrackstersPCA.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-10-2300/src/RecoHGCal/TICL/plugins/TrackstersProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-10-2300/src/RecoHGCal/TICL/plugins/filters.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-10-2300/src/RecoHGCal/TICL/plugins/SimTrackstersProducer.cc:88:33: error: 'SimToRecoCollectionWithSimClusters' is not a member of 'hgcal'; did you mean 'ticl::SimToRecoCollectionWithSimClusters'?
   88 |   const edm::EDGetTokenT associatorMapSimClusterToReco_token_;
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-10-2300/src/SimDataFormats/Associations/interface/LayerClusterToSimClusterAssociator.h:10,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-10-2300/src/RecoHGCal/TICL/plugins/SimTrackstersProducer.cc:26:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-10-2300/src/SimDataFormats/Associations/interface/LayerClusterToSimClusterAssociatorBaseImpl.h:23:7: note: 'ticl::SimToRecoCollectionWithSimClusters' declared here

cmsbuild · 2023-11-11T15:41:02Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c54897/35754/summary.html
COMMIT: b390a9b
CMSSW: CMSSW_14_0_X_2023-11-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43248/35754/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

5.15.1_TTbarFS/step1_TTbarFS.log
135.4135.4_ZEEFS_13/step1_ZEEFS_13.log
2018.12018.1_TTbarFS_13_UP18/step1_TTbarFS_13_UP18.log

Expand to see more relval errors ...

RelVals-INPUT

13234.013234.0_TTbar_14TeV+2021FS/step2_TTbar_14TeV+2021FS.log
13434.013434.0_TTbar_14TeV+2021FSPU/step2_TTbar_14TeV+2021FSPU.log
14034.014034.0_TTbar_14TeV+2023FS/step2_TTbar_14TeV+2023FS.log

Expand to see more relval errors ...

14234.0

AddOn Tests

fastsim

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 2 sec (ended on Sat Nov 11 15:43:49 2023) - exit: 256

fastsim1

[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 2 sec (ended on Sat Nov 11 15:43:52 2023) - exit: 256

fastsim2

[fastsim2:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - elapsed time: 2 sec (ended on Sat Nov 11 15:43:57 2023) - exit: 256

cmsbuild · 2023-11-13T13:02:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43248/37634

This PR adds an extra 144KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): move dictionaries next to typedefs for TrackingParticle associations #37507

cmsbuild · 2023-11-13T13:02:53Z

Pull request #43248 was updated. @rvenditti, @syuvivida, @cmsbuild, @mdhildreth, @antoniovagnerini, @srimanob, @jfernan2, @tjavaid, @civanch, @mandrenguyen, @AdrianoDee, @nothingface0 can you please check and sign again.

felicepantaleo · 2023-11-14T08:31:46Z

@cmsbuild please test

cmsbuild · 2023-11-15T10:00:18Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c54897/35782/summary.html
COMMIT: 9780d9b
CMSSW: CMSSW_14_0_X_2023-11-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43248/35782/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

23234.023234.0_TTbar_14TeV+2026D94/step3_TTbar_14TeV+2026D94.log
24834.911

----- Begin Fatal Exception 15-Nov-2023 10:50:51 CET-----------------------
An exception of category 'InvalidReference' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'validation_step9'
   [2] Calling method for module HGCalValidator/'hgcalValidator'
Exception Message:
can't find reference in AssociationMap at position 7020
----- End Fatal Exception -------------------------------------------------

cmsbuild · 2023-11-16T08:06:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43248/37726

This PR adds an extra 212KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): move dictionaries next to typedefs for TrackingParticle associations #37507

cmsbuild · 2023-11-16T08:06:46Z

Pull request #43248 was updated. @nothingface0, @tjavaid, @antoniovagnerini, @syuvivida, @civanch, @srimanob, @AdrianoDee, @cmsbuild, @rvenditti, @mdhildreth, @jfernan2, @mandrenguyen can you please check and sign again.

brusale added 3 commits November 10, 2023 10:47

enable CaloParticles creation in ECAL and HCAL for phase2

b06b838

add LCToCP and LCToSC associators in the barrel

4580c45

change namespace from hgcal to ticl

526e069

cmsbuild added this to the CMSSW_14_0_X milestone Nov 10, 2023

cmsbuild added simulation-pending dqm-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending labels Nov 10, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels Nov 10, 2023

apply code format

2019177

cmsbuild added code-checks-pending and removed code-checks-rejected labels Nov 10, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 10, 2023

cmsbuild added tests-started and removed tests-pending labels Nov 11, 2023

cmsbuild added tests-rejected and removed tests-started labels Nov 11, 2023

fix checkdeps

b390a9b

cmsbuild removed tests-rejected code-checks-approved labels Nov 11, 2023

cmsbuild added tests-started and removed tests-pending labels Nov 11, 2023

cmsbuild added tests-rejected and removed tests-started labels Nov 11, 2023

set HGCal SimHits explicitly

9780d9b

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Nov 13, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 13, 2023

cmsbuild added tests-started and removed tests-pending labels Nov 14, 2023

cmsbuild added tests-rejected and removed tests-started labels Nov 15, 2023

Merge branch 'cms-sw:master' into barrel_cp_associators

129039e

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Nov 16, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 16, 2023

brusale closed this Nov 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable CaloParticles in the barrel for Phase2 and introduce LC associations #43248

Enable CaloParticles in the barrel for Phase2 and introduce LC associations #43248

brusale commented Nov 10, 2023 •

edited

Loading

cmsbuild commented Nov 10, 2023

cmsbuild commented Nov 10, 2023

cmsbuild commented Nov 10, 2023

felicepantaleo commented Nov 11, 2023

cmsbuild commented Nov 11, 2023

cmsbuild commented Nov 11, 2023

cmsbuild commented Nov 13, 2023

cmsbuild commented Nov 13, 2023

felicepantaleo commented Nov 14, 2023

cmsbuild commented Nov 15, 2023

cmsbuild commented Nov 16, 2023

cmsbuild commented Nov 16, 2023

Enable CaloParticles in the barrel for Phase2 and introduce LC associations #43248

Enable CaloParticles in the barrel for Phase2 and introduce LC associations #43248

Conversation

brusale commented Nov 10, 2023 • edited Loading

PR description:

PR validation:

cmsbuild commented Nov 10, 2023

cmsbuild commented Nov 10, 2023

cmsbuild commented Nov 10, 2023

felicepantaleo commented Nov 11, 2023

cmsbuild commented Nov 11, 2023

Build

cmsbuild commented Nov 11, 2023

RelVals

RelVals-INPUT

AddOn Tests

cmsbuild commented Nov 13, 2023

cmsbuild commented Nov 13, 2023

felicepantaleo commented Nov 14, 2023

cmsbuild commented Nov 15, 2023

RelVals

cmsbuild commented Nov 16, 2023

cmsbuild commented Nov 16, 2023

brusale commented Nov 10, 2023 •

edited

Loading