move dictionaries next to typedefs for TrackingParticle associations

[davidlange6]

May resolve (to be confirmed...) runtime errors for missing dictionaries in modules IB. In any case, I believe it is more clear to have the dictionaries and typedefs in the same place (which I believe is in SimDataFormats/Associations for all of these)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37507/29220

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

• SimDataFormats/Associations (simulation)
• SimDataFormats/TrackingAnalysis (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@sscruz, @jhgoh, @trocino, @Fedespring, @apsallid, @felicepantaleo, @abbiendi, @JanFSchulte, @rovere, @VinInn, @bsunanda, @HuguesBrun, @ebrondol, @CeliaFernandez, @lecriste, @mmusich, @mtosi, @fabiocos, @cericeci this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a0eba/23775/summary.html
COMMIT: 91f1853
CMSSW: CMSSW_12_4_X_2022-04-08-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37507/23775/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593039
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3593009
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@davidlange6 I imagine that the duplicate dictionary error reported by the bot tests is simply due to the fact that these tests still see both the new dictionaries in SimDataFormats/Associations and the old ones in SimDataFormats/TrackingAnalysis, and it will be resolved in the IBs: is it correct?

[perrotta]

@davidlange6 I imagine that the duplicate dictionary error reported by the bot tests is simply due to the fact that these tests still see both the new dictionaries in SimDataFormats/Associations and the old ones in SimDataFormats/TrackingAnalysis, and it will be resolved once in the IBs: is it correct?

Maybe @smuzaffar can also answer this, so that we can proceed with this PR

[smuzaffar]

tests still see both the new dictionaries in SimDataFormats/Associations and the old ones in SimDataFormats/TrackingAnalysis

@perrotta , no not for this reason. We have a mapping https://github.com/cms-sw/cmssw/blob/master/Utilities/ReleaseScripts/scripts/duplicateReflexLibrarySearch.py#L49 which says any dict for TrackingParticle should come from package TrackingAnalysis . This is because TrackingParticle is defined in SimDataFormats/TrackingAnalysis

[perrotta]

tests still see both the new dictionaries in SimDataFormats/Associations and the old ones in SimDataFormats/TrackingAnalysis

@perrotta , no not for this reason. We have a mapping https://github.com/cms-sw/cmssw/blob/master/Utilities/ReleaseScripts/scripts/duplicateReflexLibrarySearch.py#L49 which says any dict for TrackingParticle should come from package TrackingAnalysis . This is because TrackingParticle is defined in SimDataFormats/TrackingAnalysis

Thank you @smuzaffar !
Then @davidlange6 I think this PR needs some fixes...

[davidlange6]

I'm then lost has where dictionaries from multiple packages should be defined. Or is tracjingparticle special? On Apr 13, 2022 10:41 AM, Andrea Perrotta ***@***.***> wrote: tests still see both the new dictionaries in SimDataFormats/Associations and the old ones in SimDataFormats/TrackingAnalysis @perrotta<https://github.com/perrotta> , no not for this reason. We have a mapping https://github.com/cms-sw/cmssw/blob/master/Utilities/ReleaseScripts/scripts/duplicateReflexLibrarySearch.py#L49 which says any dict for TrackingParticle should come from package TrackingAnalysis . This is because TrackingParticle is defined in SimDataFormats/TrackingAnalysis Thank you @smuzaffar<https://github.com/smuzaffar> ! Then @davidlange6<https://github.com/davidlange6> I think this PR needs some fixes... — Reply to this email directly, view it on GitHub<#37507 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ6N6CJGQL3PECMIA63VE2CAXANCNFSM5S5AAMBQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[smuzaffar]

If you have pack2 which depends on pack1 then dicts which require classes from both can go in pack2. If we have two or more independent packages then dict can be define in any of those or in a different package too. We just need to make sure that we have properly mapped this duplicateReflexLibrarySearch.py .

[davidlange6]

So all is probably fine except this mapping. Will double check later On Apr 13, 2022 10:58 AM, Malik Shahzad Muzaffar ***@***.***> wrote: If you have pack2 which depends on pack1 then dicts which require classes from both can go in pack2. If we have two or more independent packages then dict can be define in any of those or in a different package too. We just need to make sure that we have properly mapped this duplicateReflexLibrarySearch.py . — Reply to this email directly, view it on GitHub<#37507 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ2BAH4BK45DFEDUDIDVE2D6PANCNFSM5S5AAMBQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[cmsbuild]

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a0eba/35636/summary.html
COMMIT: 807e51b
CMSSW: CMSSW_13_3_X_2023-11-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37507/35636/install.sh to create a dev area with all the needed externals and cmssw changes.

This pull request cannot be automatically merged, could you please rebase it?
You can see the log for git cms-merge-topic here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a0eba/35636/git-merge-result

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.

[smuzaffar]

ping

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

[antoniovilela]

ping (to make bot change milestone)