-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CaloParticles in the barrel for Phase2 and generalization of the LC associators #44560
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44560/39702
|
A new Pull Request was created by @brusale for master. It involves the following packages:
@mandrenguyen, @mdhildreth, @jfernan2, @nothingface0, @srimanob, @subirsarkar, @cmsbuild, @civanch, @antoniovagnerini, @tjavaid, @syuvivida, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59b60f/38969/summary.html Comparison SummarySummary:
|
+1 |
+1 |
+1 |
@cmsbuild please test |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59b60f/39475/summary.html Comparison SummarySummary:
|
A kind reminder to merge this, as other PRs need to be rebased on top of these changes and signed again. |
+1 |
PR description:
This PR enables the building of the CaloParticles in the barrel for Phase2 and generalizes the LCToCP and LCToSC associators (described here) to be run in the barrel.
Also,
HGCalRecHitMapProducer
has been replaced byRecHitMapProducer
that may be used to create a map in the barrel as well.In addition, the associators have been moved to
namespace ticl
.PR validation:
Tested on wfs
24896.0
,24900.0
,24834.0
and224834.0
.@felicepantaleo @rovere