Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CaloParticles in the barrel for Phase2 and generalization of the LC associators #44560

Merged
merged 18 commits into from
May 29, 2024

Conversation

brusale
Copy link
Contributor

@brusale brusale commented Mar 27, 2024

PR description:

This PR enables the building of the CaloParticles in the barrel for Phase2 and generalizes the LCToCP and LCToSC associators (described here) to be run in the barrel.
Also, HGCalRecHitMapProducer has been replaced by RecHitMapProducer that may be used to create a map in the barrel as well.
In addition, the associators have been moved to namespace ticl.

PR validation:

Tested on wfs 24896.0, 24900.0, 24834.0 and 224834.0.

@felicepantaleo @rovere

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44560/39702

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @brusale for master.

It involves the following packages:

  • DataFormats/HGCRecHit (upgrade, reconstruction)
  • RecoHGCal/TICL (upgrade, reconstruction)
  • RecoLocalCalo/Configuration (reconstruction)
  • RecoLocalCalo/HGCalRecAlgos (upgrade, reconstruction)
  • RecoLocalCalo/HGCalRecProducers (upgrade, reconstruction)
  • SimCalorimetry/HGCalAssociatorProducers (upgrade, simulation)
  • SimCalorimetry/HGCalSimProducers (upgrade, simulation)
  • SimDataFormats/Associations (simulation)
  • SimDataFormats/CaloAnalysis (simulation)
  • SimGeneral/MixingModule (simulation)
  • Validation/HGCalValidation (dqm)

@mandrenguyen, @mdhildreth, @jfernan2, @nothingface0, @srimanob, @subirsarkar, @cmsbuild, @civanch, @antoniovagnerini, @tjavaid, @syuvivida, @rvenditti can you please review it and eventually sign? Thanks.
@bsunanda, @rovere, @vandreev11, @makortel, @lgray, @sethzenz, @forthommel, @edjtscott, @rchatter, @youyingli, @thomreis, @slomeo, @pfs, @sobhatta, @fabiocos, @missirol, @wang0jin, @ReyerBand, @argiro, @lecriste, @cseez, @apsallid, @felicepantaleo, @hatakeyamak, @sameasy this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@felicepantaleo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59b60f/38969/summary.html
COMMIT: 27029e2
CMSSW: CMSSW_14_1_X_2024-04-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44560/38969/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 19 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 45 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3319599
  • DQMHistoTests: Total failures: 9200
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3310379
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@tjavaid
Copy link

tjavaid commented Apr 25, 2024

+1

@civanch
Copy link
Contributor

civanch commented Apr 26, 2024

+1

@srimanob
Copy link
Contributor

@cmsbuild please test
Just refresh the test after a month. Very sorry to miss this.

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59b60f/39475/summary.html
COMMIT: 27029e2
CMSSW: CMSSW_14_1_X_2024-05-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44560/39475/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 8654
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3330188
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@felicepantaleo
Copy link
Contributor

A kind reminder to merge this, as other PRs need to be rebased on top of these changes and signed again.
@antoniovilela @rappoccio @sextonkennedy

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 34c2562 into cms-sw:master May 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants