Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-HGX350X Add a new workflow for a version containing V18 definition of HGCal #43466

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Dec 1, 2023

PR description:

Add a new workflow for a version containing V18 definition of HGCal

PR validation:

Use runTheMatrix test workflow 27234.0 designed for this scenario 2026D104

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43466/38019

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2023

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/HGCalCommonData (geometry, upgrade)

@sunilUIET, @Dr15Jones, @cmsbuild, @rappoccio, @antoniovilela, @bsunanda, @civanch, @davidlange6, @makortel, @fabiocos, @mdhildreth, @srimanob, @AdrianoDee, @miquork can you please review it and eventually sign? Thanks.
@VourMa, @sameasy, @rovere, @mmusich, @vargasa, @felicepantaleo, @VinInn, @makortel, @GiacomoSguazzoni, @fabiocos, @dgulhan, @Martin-Grunewald, @missirol, @mtosi, @slomeo, @JanFSchulte this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Dec 1, 2023

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-204a05/36237/summary.html
COMMIT: 5c23d2b
CMSSW: CMSSW_14_0_X_2023-11-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43466/36237/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 63 lines to the logs
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3370032
  • DQMHistoTests: Total failures: 73
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3369937
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Contributor Author

bsunanda commented Dec 1, 2023

+geometry

@bsunanda
Copy link
Contributor Author

bsunanda commented Dec 1, 2023

@sunilUIET Can you approve this?

@sunilUIET
Copy link
Contributor

+pdmv

@bsunanda
Copy link
Contributor Author

bsunanda commented Dec 1, 2023

@srimanob Can you approve this please?

@civanch
Copy link
Contributor

civanch commented Dec 1, 2023

+1

@srimanob
Copy link
Contributor

srimanob commented Dec 2, 2023

test parameters:

  • workflow = 27234.0
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

@srimanob
Copy link
Contributor

srimanob commented Dec 2, 2023

@cmsbuild please test

We should test the new workflow in the PR.

@srimanob
Copy link
Contributor

srimanob commented Dec 2, 2023

FYI @fabiocos @24LopezR
I propose to merge this PR first. Then ETL (#43407) on top with new defined D105. Thx.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-204a05/36276/summary.html
COMMIT: 5c23d2b
CMSSW: CMSSW_14_0_X_2023-12-01-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43466/36276/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3370032
  • DQMHistoTests: Total failures: 85
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3369925
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

srimanob commented Dec 2, 2023

@bsunanda @cms-sw/trk-dpg-l2

The output of D104 is very very noisy in RECO step. I think it does not relate to this PR, but tracker T35. I may missed it when we integrated D102 which uses T35 also. If this is confirmed, I will sign the PR, and open the issue to follow up. Thx.

%MSG-e SiPixelLorentzAngle:   PixelCPEGenericESProducer:PixelCPEGenericESProducer@callESModule  02-Dec-2023 11:52:15 CET Run: 1 Event: 1
SiPixelLorentzAngle for DetID 303042565 is not stored
%MSG
%MSG-e SiPixelLorentzAngle:   PixelCPEGenericESProducer:PixelCPEGenericESProducer@callESModule  02-Dec-2023 11:52:15 CET Run: 1 Event: 1
SiPixelLorentzAngle for DetID 303042566 is not stored
%MSG
%MSG-e SiPixelLorentzAngle:   PixelCPEGenericESProducer:PixelCPEGenericESProducer@callESModule  02-Dec-2023 11:52:15 CET Run: 1 Event: 1
SiPixelLorentzAngle for DetID 303042569 is not stored
%MSG
%MSG-e SiPixelLorentzAngle:   PixelCPEGenericESProducer:PixelCPEGenericESProducer@callESModule  02-Dec-2023 11:52:15 CET Run: 1 Event: 1
SiPixelLorentzAngle for DetID 303042570 is not stored
%MSG
%MSG-e SiPixelLorentzAngle:   PixelCPEGenericESProducer:PixelCPEGenericESProducer@callESModule  02-Dec-2023 11:52:15 CET Run: 1 Event: 1
SiPixelLorentzAngle for DetID 303042573 is not stored
%MSG
%MSG-e SiPixelLorentzAngle:   PixelCPEGenericESProducer:PixelCPEGenericESProducer@callESModule  02-Dec-2023 11:52:15 CET Run: 1 Event: 1
SiPixelLorentzAngle for DetID 303042574 is not stored
%MSG
%MSG-e SiPixelLorentzAngle:   PixelCPEGenericESProducer:PixelCPEGenericESProducer@callESModule  02-Dec-2023 11:52:15 CET Run: 1 Event: 1
SiPixelLorentzAngle for DetID 303042577 is not stored

@mmusich
Copy link
Contributor

mmusich commented Dec 2, 2023

@srimanob

The output of D104 is very very noisy in RECO step. I think it does not relate to this PR, but tracker T35. I may missed it when we integrated D102 which uses T35 also. If this is confirmed, I will sign the PR, and open the issue to follow up. Thx.

this happens because in #41880 it was forgotten to update the labels forWidth and fromAlignment in the map at autoCondPhase2, hence the relval job reads the ones (not being overridden) in the physical GT auto:phase2_realistic. Since this latter is based off geometry T21 it doesn't have the split sensors in BPix1, thus the error messages. This is followed up at #43482 .

@srimanob
Copy link
Contributor

srimanob commented Dec 2, 2023

+Upgrade

Thanks @mmusich to follow up on the tracker complain.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 9ffa722 into cms-sw:master Dec 4, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants