-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-gex174 Add RPD in the latest version of 2023 Gemetry as requested by the ZDC group for the next HI simulation effort #43418
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43418/37934
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@mdhildreth, @cmsbuild, @Dr15Jones, @srimanob, @bsunanda, @civanch, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c42c71/36121/summary.html Comparison SummarySummary:
|
+1 |
@srimanob Please approve this |
…from cms-sw#43418 and earlier pull requests for GE21 and HCAL
…un3 geometry to be used for te Heavy Ion MC
…un3 geometry to be used for te Heavy Ion MC
@srimanob Please approve this PR. It is urgently needed. Without this in the IB, the back ports do 13_X_Y does not make sense. Please do this at your earliest convenience |
@smuzaffar @markotel This deals with Run3 geometry. I wonder why upgrade signature is needed for this. |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
Actually, I am not clear in the PR after read the PR description again. The change applied to 2023 geometry. Is this mean that this geometry is good also for future 2023 MC, i.e. legacy at the end of Run-3? Or this is specific for HI only. Any reference doc or meeting on the change should be ref. |
I read the slide. On page 7, you mention only Run-3 HI. But if we put the PR in this way, the future 2023 will include this by default. Is this something expected? |
Because according to https://github.com/cms-sw/cms-bot/blob/master/categories_map.py these two packages should be reviewed also by |
Upgrade is here just because we don't split between Run-3 and Phase-2. I understand that we don't have a way to split reviewers within the same sub-category. The upgrade sw will be diluted when Phase-2 becomes default to us. |
This PR is needed to update 2024 Run3 production. Because ZDC is far away of central detector it cannot effect any existing calibration. The status of ZDC for Phase-2 needs to be evaluated but in the first view there should be no effect. |
+1 |
Run3-gex174C Backport the fix in #43418 on ZDC geometry to update the 2023 Run3 geometry to be used for te Heavy Ion MC
Run3-174D Backport the fix in #43418 on ZDC geometry to update the 2023 Run3 geometry to be used for te Heavy Ion MC
…un3 geometry to be used for the Heavy Ion MC
Run3-174I Backport the fix in #43418 on ZDC geometry to update the 2023 Run3 geometry to be used for the Heavy Ion MC
PR description:
Add RPD in the latest version of 2023 Gemetry as requested by the ZDC group for the next HI simulation effort
PR validation:
Test using th4 g4 overlap tool
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
May be required to be backported to 13_2_X for HI simulation effort