Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex174E Backport the fix in #43418 on ZDC geometry to update the 2023 Run3 geometry to be used for the Heavy Ion MC #43479

Closed
wants to merge 1 commit into from

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Dec 1, 2023

PR description:

Backport the fix in #43418 on ZDC geometry to update the 2023 Run3 geometry to be used for the Heavy Ion MC

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be used for HI MC. Needed to make the payload

…un3 geometry to be used for te Heavy Ion MC
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2023

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/Geometry (upgrade, geometry)
  • Geometry/CMSCommonData (upgrade, geometry)
  • Geometry/ForwardCommonData (geometry)
  • Geometry/ForwardSimData (geometry)

@srimanob, @Dr15Jones, @cmsbuild, @mdhildreth, @civanch, @bsunanda, @makortel can you please review it and eventually sign? Thanks.
@slomeo, @Martin-Grunewald, @fabiocos, @vargasa, @missirol this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Dec 1, 2023

@cmsbuild Please test

@bsunanda
Copy link
Contributor Author

bsunanda commented Dec 1, 2023

+geometry

@bsunanda
Copy link
Contributor Author

bsunanda commented Dec 1, 2023

@srimanob This is purely Run3 geometry. I do not see why upgrade signature is needed for this. Please sign this to be integrated

@srimanob
Copy link
Contributor

srimanob commented Dec 1, 2023

Is this backport discussed already with PPD?
13_0 is not only for HI, but also pp. If we need only for HI, should we just add 2023HI geometry instead of replacing 2023?

Sorry if this is already discussed. I am almost out since beginning of Nov. I signed the master because the fix can propagate to future MC like legacy.

@cms-sw/alca-l2 @cms-sw/pdmv-l2

@bsunanda
Copy link
Contributor Author

bsunanda commented Dec 1, 2023

@srimanob Yes, it is discussed. With this back ported we can make the payload and then with the new payload MC can start using 13_0_HI

@srimanob
Copy link
Contributor

srimanob commented Dec 1, 2023

Could you please clarify on this question, #43418 (comment)

thanks.

@srimanob
Copy link
Contributor

srimanob commented Dec 1, 2023

Alca slide on 27 Nov mentioned about pending decision. I assume the decision is made, right?

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-691e83/36271/summary.html
COMMIT: 792cfc6
CMSSW: CMSSW_13_0_X_2023-11-26-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43479/36271/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@civanch
Copy link
Contributor

civanch commented Dec 2, 2023

This backport is needed, because #43455 cannot be tested in the current test system. Because this PR is identical to #43455, the test for13_0_HeavyIons_X is done. From my point of view, this PR may be also merged, because does not disturb anything but it is up to release managers to decide.

@srimanob
Copy link
Contributor

srimanob commented Dec 3, 2023

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

This backport is needed, because #43455 cannot be tested in the current test system. Because this PR is identical to #43455, the test for13_0_HeavyIons_X is done. From my point of view, this PR may be also merged, because does not disturb anything but it is up to release managers to decide.

We will follow up on the integration tests for CMSSW_13_0_HeavyIon_X and hold for the moment this PR in 13_0_X.

@antoniovilela
Copy link
Contributor

hold

  • Hold integration in 13_0_X as this is intended for CMSSW_13_0_HeavyIon_X .

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2023

Pull request has been put on hold by @antoniovilela
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@civanch
Copy link
Contributor

civanch commented Dec 7, 2023

@antoniovilela , @rappoccio , I guess this PR may be unhold.

@civanch
Copy link
Contributor

civanch commented Dec 12, 2023

@bsunanda , it is agreed to close this PR.

@rappoccio rappoccio closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants