Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hack EgammaHLTR9IDProducer to be able to run it in Phase2 HLT #44358

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Hack EgammaHLTR9IDProducer to be able to run it in Phase2 HLT #44358

merged 2 commits into from
Mar 11, 2024

Conversation

swagata87
Copy link
Contributor

PR description:

Currently, in Phase2 HLT, we do not use R9 variable. But it will be good to explore the potential of this variable at Phase2 HLT, as this variable was useful in Run3/Run2 HLT. With this PR, it is now possible to run EgammaHLTR9IDProducer on Phase2 samples. The R9 distribution, that was obtained by running on one root file of this sample[1], is meaningful, and is pasted below.

[1] /RelValH125GGgluonfusion_14/CMSSW_14_0_0_pre3-140X_mcRun4_realistic_v1_STD_2026D98_noPU-v1/GEN-SIM-DIGI-RAW

r9

PR validation:

CMSSW compiles. Phase2 HLT menu runs fine.

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Mar 8, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024 •
edited
Loading

cms-bot internal usage

@swagata87
Copy link
Contributor Author

type egamma

@cmsbuild cmsbuild added the egamma label Mar 8, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44358/39396

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

A new Pull Request was created by @swagata87 for master.

It involves the following packages:

  • RecoEgamma/EgammaHLTProducers (hlt)

@mmusich, @cmsbuild, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@afiqaize, @a-kapoor, @Sam-Harper, @varuns23, @Prasant1993, @cericeci, @missirol, @Fedespring, @valsdav, @silviodonato, @HuguesBrun, @sobhatta, @ram1123, @sameasy, @lgray, @jainshilpi this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f16fac/37998/summary.html
COMMIT: ce9f93d
CMSSW: CMSSW_14_1_X_2024-03-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44358/37998/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

swagata87
swagata87 commented Mar 9, 2024
View reviewed changes
RecoEgamma/EgammaHLTProducers/plugins/EgammaHLTR9IDProducer.cc Outdated

if (recoecalcandref->superCluster()->seed()->seed().det() != DetId::Ecal) { //HGCAL, skip for now
r9Map.insert(recoecalcandref, 0);
r95x5Map.insert(recoecalcandref, 0);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually the default value for HGCAL should be 1 (not 0). Because R9 cut in phase2 HLT paths will be of the form R9>some_value_around_0.9. So if it's set to 1 in HGCAL then it will always pass, as intended. I will make this change soon.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44358/39404

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2024

Pull request #44358 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

@swagata87
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f16fac/38006/summary.html
COMMIT: d9aaa9d
CMSSW: CMSSW_14_1_X_2024-03-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44358/38006/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@Martin-Grunewald
Copy link
Contributor

@swagata87
Presumably we need a backport to 14_0?

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@swagata87 swagata87 mentioned this pull request Mar 11, 2024
Merged
@swagata87
Copy link
Contributor Author

Presumably we need a backport to 14_0?

indeed, here is the backport #44365

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 24a061a into cms-sw:master Mar 11, 2024
11 checks passed
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved egamma fully-signed hlt-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@swagata87 @cmsbuild @Martin-Grunewald @antoniovilela