Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable vectorization of lwtnn, opencv and pytorch #9061

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Mar 11, 2024

This change actually enable the building of vectorization packages for lwtnn, opencv and pytorch for multi-arch IB/releases

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master.

@iarspider, @smuzaffar, @aandvalenzuela can you please review it and eventually sign? Thanks.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 11, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_1_MULTIARCHS_X/el8_amd64_gcc12

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b88baa/38042/summary.html
COMMIT: d73ee3d
CMSSW: CMSSW_14_1_X_2024-03-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9061/38042/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b88baa/38042/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b88baa/38042/git-merge-result

Comparison Summary

Summary:

  • You potentially added 122 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 178 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297383
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3297363
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 5 / 46 workflows

@antoniovilela
Copy link

@smuzaffar
Hi Shahzad, all good here?
Thanks.

@smuzaffar
Copy link
Contributor Author

+externals

every thing looks good for multi-arch build. merging it for tonight IB

@smuzaffar smuzaffar merged commit 6591182 into IB/CMSSW_14_1_X/master Mar 12, 2024
14 of 15 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor Author

@smuzaffar Hi Shahzad, all good here? Thanks.

yes all look good for this change. you can merge #9062 tomorrow morning before 11h00 IB

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b88baa/38046/summary.html
COMMIT: d73ee3d
CMSSW: CMSSW_14_1_MULTIARCHS_X_2024-03-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9061/38046/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b88baa/38046/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b88baa/38046/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 590 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 68092 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297383
  • DQMHistoTests: Total failures: 147145
  • DQMHistoTests: Total nulls: 272
  • DQMHistoTests: Total successes: 3149946
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -4.849 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 13034.0 ): -0.854 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 140.063 ): -0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.042 ): 0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): -0.031 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): -0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): -0.421 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.225 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 1.533 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -4.839 KiB SiStrip/MechanicalView
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 17 / 46 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants