Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invalid tool from L1Trigger/L1TZDC #44361

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Remove invalid tool from L1Trigger/L1TZDC #44361

merged 1 commit into from
Mar 11, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 10, 2024

PR description:

Building the package L1Trigger/L1TZDC prints the warning

****WARNING: Invalid tool L1Trigger/L1TZDC. Please fix src/L1Trigger/L1TZDC/plugins/BuildFile.xml file.

L1Trigger/L1TZDC is not a valid dependency, because it does not have interface/ and src/ directories, and does not provide a BuildFile.xml.

This change removed the dependency on it.

PR validation:

None.

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 10, 2024

please test

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Mar 10, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 10, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44361/39406

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • L1Trigger/L1TZDC (l1)

@epalencia, @aloeliger can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe79b7/38013/summary.html
COMMIT: 9a8ca65
CMSSW: CMSSW_14_1_X_2024-03-10-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44361/38013/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 4.534.53_RunPhoton2012B/step2_RunPhoton2012B.log
  • 5.15.1_TTbarFS/step1_TTbarFS.log
  • 7.37.3_CosmicsSPLoose2018/step1_CosmicsSPLoose2018.log
Expand to see more relval errors ...

RelVals-INPUT

  • 4.174.17_RunMinBias2011A/step2_RunMinBias2011A.log
  • 4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
  • 4.264.26_ZMuSkim2011A/step2_ZMuSkim2011A.log
Expand to see more relval errors ...

AddOn Tests

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 2 sec (ended on Sun Mar 10 13:31:23 2024) - exit: 256

[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 1 sec (ended on Sun Mar 10 13:31:24 2024) - exit: 256

[fastsim2:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - elapsed time: 1 sec (ended on Sun Mar 10 13:31:29 2024) - exit: 256
Expand to see more addon errors ...

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 10, 2024

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe79b7/38014/summary.html
COMMIT: 9a8ca65
CMSSW: CMSSW_14_1_X_2024-03-10-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44361/38014/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 4.534.53_RunPhoton2012B/step2_RunPhoton2012B.log
  • 5.15.1_TTbarFS/step1_TTbarFS.log
  • 4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
Expand to see more relval errors ...

RelVals-INPUT

  • 4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
  • 4.264.26_ZMuSkim2011A/step2_ZMuSkim2011A.log
  • 4.234.23_ValSkim2011A/step2_ValSkim2011A.log
Expand to see more relval errors ...

AddOn Tests

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 1 sec (ended on Sun Mar 10 15:42:05 2024) - exit: 256

[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 1 sec (ended on Sun Mar 10 15:42:07 2024) - exit: 256

[fastsim2:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - elapsed time: 1 sec (ended on Sun Mar 10 15:42:10 2024) - exit: 256
Expand to see more addon errors ...

@Martin-Grunewald
Copy link
Contributor

please test with #44362

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe79b7/38025/summary.html
COMMIT: 9a8ca65
CMSSW: CMSSW_14_1_X_2024-03-10-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44361/38025/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 19192 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 66 log files, 0 edm output root files, 1 DQM output files

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

type bug-fix

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2e5dc6d into cms-sw:master Mar 11, 2024
11 checks passed
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
@fwyzard fwyzard deleted the fix_L1Trigger_L1TZDC_plugins_BuildFile branch April 7, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix code-checks-approved fully-signed l1-approved orp-approved requires-external tests-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
5 participants
@fwyzard @cmsbuild @Martin-Grunewald @aloeliger @antoniovilela