Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NanoAOD flavours parameter to PromptReco #44430

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

germanfgv
Copy link
Contributor

@germanfgv germanfgv commented Mar 15, 2024

PR description:

Adds the capacity to specify flavours for NanoAOD in PromptReco

PR validation:

Using the updated RunPromptReco.py with --nanoFlavours=@PHYS+@MUPOG, ConfigBuilder shows the proper flavours:

$ python3 Configuration/DataProcessing/test/RunPromptReco.py --scenario=ppEra_Run3_2023 --reco --aod --miniaod --nanoaod --dqmio --global-tag 140X_dataRun3_Prompt_v2 --lfn=file:/eos/cms/tier0/store/backfill/1/data/Tier0_REPLAY_2024/Muon0/RAW/v13033023/000/369/998/00000/0181983c-310f-4b2e-8d66-57d58a3bf1c1.root --PhysicsSkims=ZMu+EXODisappTrk+LogError+LogErrorMonitor+EXOCSCCluster+EXODisappMuon --nanoFlavours=@PHYS+@MUPOG
Retrieved Scenario: ppEra_Run3_2023
...
Step: RAW2DIGI Spec: 
Step: L1Reco Spec: 
Step: RECO Spec: 
Step: ALCAPRODUCER Spec: ['@allForPrompt']
Step: SKIM Spec: ['ZMu', 'EXODisappTrk', 'LogError', 'LogErrorMonitor', 'EXOCSCCluster', 'EXODisappMuon']
Step: PAT Spec: 
Step: NANO Spec: ['@PHYS', '@MUPOG']
in prepare_nano @PHYS+@MUPOG
Step: DQM Spec: 
...

Here without --nanoFlavours:

$ python3 Configuration/DataProcessing/test/RunPromptReco.py --scenario=ppEra_Run3_2023 --reco --aod --miniaod --nanoaod --dqmio --global-tag 140X_dataRun3_Prompt_v2 --lfn=file:/eos/cms/tier0/store/backfill/1/data/Tier0_REPLAY_2024/Muon0/RAW/v13033023/000/369/998/00000/0181983c-310f-4b2e-8d66-57d58a3bf1c1.root --PhysicsSkims=ZMu+EXODisappTrk+LogError+LogErrorMonitor+EXOCSCCluster+EXODisappMuon                            
Retrieved Scenario: ppEra_Run3_2023
...
Step: RAW2DIGI Spec: 
Step: L1Reco Spec: 
Step: RECO Spec: 
Step: ALCAPRODUCER Spec: ['@allForPrompt']
Step: SKIM Spec: ['ZMu', 'EXODisappTrk', 'LogError', 'LogErrorMonitor', 'EXOCSCCluster', 'EXODisappMuon']
Step: PAT Spec: 
Step: NANO Spec: 
in prepare_nano nanoSequence
Step: DQM Spec: 
...

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to CMSSW_14_0_X
Backport: #44454

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 15, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44430/39504

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @germanfgv for master.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@davidlange6, @rappoccio, @antoniovilela, @cmsbuild, @fabiocos can you please review it and eventually sign? Thanks.
@fabiocos, @missirol, @Martin-Grunewald this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Mar 16, 2024

should this functionality be added to the Configuration/DataProcessing unit tests?

@germanfgv
Copy link
Contributor Author

should this functionality be added to the Configuration/DataProcessing unit tests?

You are probably right. I'll do so.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44430/39523

@cmsbuild
Copy link
Contributor

Pull request #44430 was updated. @davidlange6, @cmsbuild, @rappoccio, @antoniovilela, @fabiocos can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Mar 18, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7512b5/38226/summary.html
COMMIT: 5dffd55
CMSSW: CMSSW_14_1_X_2024-03-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44430/38226/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@antoniovilela
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

ping bot

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants