Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Add NanoAOD flavours parameter to PromptReco #44454

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

germanfgv
Copy link
Contributor

PR description:

Adds the capacity to specify flavours for NanoAOD in PromptReco

PR validation:

Using the updated RunPromptReco.py with --nanoFlavours=@PHYS+@MUPOG, ConfigBuilder shows the proper flavours:

$ python3 Configuration/DataProcessing/test/RunPromptReco.py --scenario=ppEra_Run3_2023 --reco --aod --miniaod --nanoaod --dqmio --global-tag 140X_dataRun3_Prompt_v2 --lfn=file:/eos/cms/tier0/store/backfill/1/data/Tier0_REPLAY_2024/Muon0/RAW/v13033023/000/369/998/00000/0181983c-310f-4b2e-8d66-57d58a3bf1c1.root --PhysicsSkims=ZMu+EXODisappTrk+LogError+LogErrorMonitor+EXOCSCCluster+EXODisappMuon --nanoFlavours=@PHYS+@MUPOG
Retrieved Scenario: ppEra_Run3_2023
...
Step: RAW2DIGI Spec: 
Step: L1Reco Spec: 
Step: RECO Spec: 
Step: ALCAPRODUCER Spec: ['@allForPrompt']
Step: SKIM Spec: ['ZMu', 'EXODisappTrk', 'LogError', 'LogErrorMonitor', 'EXOCSCCluster', 'EXODisappMuon']
Step: PAT Spec: 
Step: NANO Spec: ['@PHYS', '@MUPOG']
in prepare_nano @PHYS+@MUPOG
Step: DQM Spec: 
...

Here without --nanoFlavours:

$ python3 Configuration/DataProcessing/test/RunPromptReco.py --scenario=ppEra_Run3_2023 --reco --aod --miniaod --nanoaod --dqmio --global-tag 140X_dataRun3_Prompt_v2 --lfn=file:/eos/cms/tier0/store/backfill/1/data/Tier0_REPLAY_2024/Muon0/RAW/v13033023/000/369/998/00000/0181983c-310f-4b2e-8d66-57d58a3bf1c1.root --PhysicsSkims=ZMu+EXODisappTrk+LogError+LogErrorMonitor+EXOCSCCluster+EXODisappMuon                            
Retrieved Scenario: ppEra_Run3_2023
...
Step: RAW2DIGI Spec: 
Step: L1

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Original PR is #44430

@germanfgv germanfgv changed the title T0 auto nano 140 x [14_0_X] Add NanoAOD flavours parameter to PromptReco Mar 18, 2024
@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Mar 18, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 18, 2024

A new Pull Request was created by @germanfgv for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@davidlange6, @antoniovilela, @rappoccio, @cmsbuild, @fabiocos can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 18, 2024

cms-bot internal usage

@antoniovilela
Copy link
Contributor

backport of #44430

@antoniovilela
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56df6c/38266/summary.html
COMMIT: ff788e4
CMSSW: CMSSW_14_0_X_2024-03-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44454/38266/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 103 lines to the logs
  • Reco comparison results: 45 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3346212
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3346184
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 67b5776 into cms-sw:CMSSW_14_0_X Mar 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants