Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase 2 GTT L1TrackObjectNtupleMaker fixes #44911

Merged
merged 6 commits into from
May 23, 2024

Conversation

NJManganelli
Copy link
Contributor

PR description:

This PR aggregates various fixes for the GTT L1TrackObjectNtupleMaker, from cms-l1t-offline#1253 and cms-l1t-offline#1255

PR validation:

This PR passes:
scram b
scram b code-checks
scram b code-format
cmsRun L1TrackObjectNtupleMaker_cfg.py
(L1TrackObjectNtupleMaker is not called in any central workflows)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a forward port of cms-l1t-offline#1253 and cms-l1t-offline#1255

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44911/40190

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2024

A new Pull Request was created by @NJManganelli for master.

It involves the following packages:

  • L1Trigger/L1TTrackMatch (l1, upgrade)

@cmsbuild, @subirsarkar, @srimanob, @aloeliger, @epalencia can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@epalencia
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1fbdb7/39271/summary.html
COMMIT: 3e4d298
CMSSW: CMSSW_14_1_X_2024-05-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44911/39271/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 15 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3332476
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3332444
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@NJManganelli
Copy link
Contributor Author

Dear @epalencia @aloeliger , depending on what the plan is for the Integration branch, I can switch this from draft to ready. The only changes would be those in the IB PRs and any review feedback, nothing else is planned from our side.

@cgsavard

@epalencia
Copy link
Contributor

@NJManganelli , as far as I'm concerned, you can move this to ready.

@NJManganelli NJManganelli marked this pull request as ready for review May 15, 2024 16:56
@aloeliger
Copy link
Contributor

+l1

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d9d986f into cms-sw:master May 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants