clang-tidy: Remove deprecated AnalyzeTemporaryDtors option

[smuzaffar]

AnalyzeTemporaryDtors option was deprecated in llvm 16 and remove din llvm18 (llvm/llvm-project#62020)
This PR removes it from cmssw clang-tidy configuration.

[cmsbuild]

cms-bot internal usage

[smuzaffar]

test parameters:

• addpkg = Utilities/ReleaseScripts

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45034/40327

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• .clang-tidy (core)

@smuzaffar, @makortel, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57c165/39501/summary.html
COMMIT: bbfe93e
CMSSW: CMSSW_14_1_X_2024-05-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45034/39501/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @TomasKello TkAlignment: Multi-IOV Zmumu mode, fixes to DMR averaged, PV trends #45015
• @NJManganelli Phase 2 GTT L1TrackObjectNtupleMaker fixes #44911
• @mmusich fix testTkHistoMap_cfg.py to include TrackerAdditionalParametersPerDet ESSource #45013
• @mmusich update data used for the Pixel,ECal,HCal GPU online DQM clients for post-alpaka migration in the HLT menu #44971
• @smuzaffar VertexFinder: Fix unused variable warnings #45019
• @AdrianoDee Introducing DIGInoHLT + HLTOnly Steps #44964

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57c165/39501/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57c165/39501/git-merge-result

Unit Tests

I found 3 errors in the following unit tests:

---> test TestDQMOnlineClient-ecalgpu_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-hcalgpu_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-pixelgpu_dqm_sourceclient had ERRORS

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338836
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57c165/39506/summary.html
COMMIT: bbfe93e
CMSSW: CMSSW_14_1_X_2024-05-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45034/39506/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338839
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1