Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TkAlignment: Multi-IOV Zmumu mode, fixes to DMR averaged, PV trends #45015

Merged
merged 1 commit into from
May 23, 2024

Conversation

TomasKello
Copy link
Contributor

@TomasKello TomasKello commented May 22, 2024

This PR introduces following updates to the TkAl All-in-one validation tool:

  • multi-IOV mode for the Zmumu validation tool
  • small fixes to the PV trend and DMR luminosity-weighted validation tools

PR validation: code-checks, code-format and successful unit tests
FYI: @henriettepetersen

@cmsbuild
Copy link
Contributor

cmsbuild commented May 22, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45015/40300

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @TomasKello for master.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@saumyaphor4252, @cmsbuild, @perrotta, @consuegs can you please review it and eventually sign? Thanks.
@mmusich, @tlampen, @tocheng, @rsreds, @adewit, @yuanchao this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented May 22, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45b968/39468/summary.html
COMMIT: 7655768
CMSSW: CMSSW_14_1_X_2024-05-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45015/39468/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@TomasKello
Copy link
Contributor Author

I would also like to create backport to CMSSW_14_0_X such as we can benefit from it in ongoing ReReco and data-taking alignment campaigns. Is that feasible? Thx

@perrotta
Copy link
Contributor

I would also like to create backport to CMSSW_14_0_X such as we can benefit from it in ongoing ReReco and data-taking alignment campaigns. Is that feasible? Thx

Please go ahead @TomasKello : as usual, I will sign it for AlCa as soon as this master version of the PR is merged, and IB tests show no issues with it

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7e6d5a7 into cms-sw:master May 23, 2024
11 checks passed
@TomasKello TomasKello deleted the kello-updateMay2024 branch October 3, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants