Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update data used for the Pixel,ECal,HCal GPU online DQM clients for post-alpaka migration in the HLT menu #44971

Merged
merged 1 commit into from
May 23, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 15, 2024

PR description:

This PR (joint with the corresponding cms-data update cms-data/DQM-Integration#7), is meant to supply to the Pixel, ECal and HCal GPU clients fresher streamer input files for the unit tests.
This is needed because starting from online GRun menus V1.1.x in 2024, the naming of the collections in output to the DQMGPUvsCPU stream has been updated (see TSG ticket CMSHLT-3132).
This has prompted cmssw PRs in order to comply with the changes:

Due to that, the data used in unit tests currently running in IB and PR tests is out-of-synch with the collection names requested by the clients, see e.g. these logs.
The purpose of this PR (joint to the companion cms-data update cms-data/DQM-Integration#7) is to update the data used for the tests to a fresher set coming from run380649 (from Run2024D pp run OMS link), which features the new collection names.

PR validation:

Unit tests:

scram b runtests_TestDQMOnlineClient-ecalgpu_dqm_sourceclient
scram b runtests_TestDQMOnlineClient-hcalgpu_dqm_sourceclient
scram b runtests_TestDQMOnlineClient-pixelgpu_dqm_sourceclient

now run fine, and without missing collection warnings.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, might be useful to backport to 14.0.X if accepted.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 15, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented May 15, 2024

test parameters:

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44971/40255

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/Integration (dqm)

@cmsbuild, @antoniovagnerini, @syuvivida, @rvenditti, @tjavaid, @nothingface0 can you please review it and eventually sign? Thanks.
@threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented May 15, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82225c/39382/summary.html
COMMIT: 4bad6d5
CMSSW: CMSSW_14_1_X_2024-05-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44971/39382/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82225c/39382/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82225c/39382/git-merge-result

RelVals-INPUT

  • 4.764.76_ZMuSkim2012D/step2_ZMuSkim2012D.log

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338976
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338953
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented May 16, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82225c/39401/summary.html
COMMIT: 4bad6d5
CMSSW: CMSSW_14_1_X_2024-05-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44971/39401/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82225c/39401/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82225c/39401/git-merge-result

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • Reco comparison results: 3590 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338976
  • DQMHistoTests: Total failures: 5326
  • DQMHistoTests: Total nulls: 72
  • DQMHistoTests: Total successes: 3333558
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 1 / 46 workflows

@tjavaid
Copy link

tjavaid commented May 23, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/DQM-Integration#7

@antoniovilela
Copy link
Contributor

cms-data/DQM-Integration#7 merged.
cmsdist PR: cms-sw/cmsdist#9204

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9012dcc into cms-sw:master May 23, 2024
12 checks passed
@mmusich mmusich deleted the mm_dev_update_run_forGPUclientTests branch May 23, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants