Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Pixel GPU client: fix siPixelPhase1RawDataErrorComparator collections post-alpaka migration #44934

Merged
merged 1 commit into from
May 10, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 8, 2024

backport of #44933

PR description:

Title says it all, provide right collections to be monitored by the DQM/Integration/python/clients/pixelgpu_dqm_sourceclient-live_cfg.py after the pixel local reconstruction at HLT migration to alpaka (cf https://its.cern.ch/jira/browse/CMSHLT-3125 and https://its.cern.ch/jira/browse/CMSHLT-3132).
Noticed that in recent runs all plots are empty (see e.g. link) and confirmed by looking at the dqm-square logs e.g.:

%MSG-e SiPixelPhase1RawDataErrorComparator:   SiPixelPhase1RawDataErrorComparator:siPixelPhase1RawDataErrorComparator  08-May-2024 18:58:22 CEST Run: 380509 Event: 5010
reference (cpu) SiPixelRawDataErrors collection (hltSiPixelDigisLegacy) not found; 
the comparison will not run.
%MSG

PR validation:

None, the streamer files used for input tests need to be updated.
Validation will rely on a DQM replay.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #44933 to the 2024 data-taking release.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • DQM/Integration (dqm)

@nothingface0, @antoniovagnerini, @syuvivida, @tjavaid, @cmsbuild, @rvenditti can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @threus this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented May 8, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented May 8, 2024

@syuvivida is it possible to test this in a DQM playback and if successful deploy online urgently ?

@mmusich
Copy link
Contributor Author

mmusich commented May 8, 2024

type trk, bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

Pull request #44934 was updated. @nothingface0, @cmsbuild, @antoniovagnerini, @tjavaid, @rvenditti, @syuvivida can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented May 8, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfe496/39311/summary.html
COMMIT: 50b5085
CMSSW: CMSSW_14_0_X_2024-05-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44934/39311/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 30 lines from the logs
  • Reco comparison results: 68 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3327413
  • DQMHistoTests: Total failures: 1207
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3326185
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented May 9, 2024

urgent

@tjavaid
Copy link

tjavaid commented May 10, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants