Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPP20] Remove volatile from CondCore/Utilities #45104

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

francescobrivio
Copy link
Contributor

PR description:

Addressing #45072
This PR removes the only occurrence of a volatile variable in CondCore/Utilities.
The cpp script containing such variable is not run in production and not even run as unitTest.

The [RFC] in the title is due to the fact that I'm not 100% sure this is the correct way of handling this, at least I could not understand if there are preferred ways to address this deprecation from the link in the original issue, but I don't have much experience with this. 😄
@iarspider @VinInn any feedback is more than welcome.

PR validation:

Code compiles.
Additionally, I have run the following command:

conddb_test_gt_perf -g 80X_dataRun2_HLT_for800Validatio_test -n 1 -c oracle://cms_orcoff_prep/CMS_CONDITIONS --n_fetch 1 --n_deser 1 2>&1 | tee run.log

with and without this PR and the test passes with the same result.

Backport:

Not a backport, no backport needed

@cmsbuild
Copy link
Contributor

cmsbuild commented May 30, 2024

cms-bot internal usage

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test for CMSSW_14_1_CPP20_X

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45104/40432

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • CondCore/Utilities (db)

@saumyaphor4252, @perrotta, @consuegs, @francescobrivio can you please review it and eventually sign? Thanks.
@PonIlya, @yuanchao, @rsreds, @JanChyczynski, @mmusich this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@@ -325,7 +325,7 @@ cond::TestGTPerf::TestGTPerf() : Utilities("conddb_test_gt_load") {
// thread helpers

// global counter for dummy thread measurements:
volatile int fooGlobal = 0;
int fooGlobal = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this should be std::atomic<int>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vincenzo! I'll go with that then.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8245ec/39630/summary.html
COMMIT: 8727209
CMSSW: CMSSW_14_1_CPP20_X_2024-05-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45104/39630/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8245ec/39630/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8245ec/39630/git-merge-result

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45104/40441

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #45104 was updated. @cmsbuild, @francescobrivio, @consuegs, @saumyaphor4252, @perrotta can you please check and sign again.

@francescobrivio
Copy link
Contributor Author

please test for CMSSW_14_1_CPP20_X

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8245ec/39639/summary.html
COMMIT: 8c32195
CMSSW: CMSSW_14_1_CPP20_X_2024-05-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45104/39639/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8245ec/39639/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8245ec/39639/git-merge-result

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

perrotta commented Jun 1, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8245ec/39660/summary.html
COMMIT: 8c32195
CMSSW: CMSSW_14_1_X_2024-06-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45104/39660/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338833
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@francescobrivio francescobrivio changed the title [RFC] [CPP20] Remove volatile from CondCore/Utilities [CPP20] Remove volatile from CondCore/Utilities Jun 5, 2024
@perrotta
Copy link
Contributor

perrotta commented Jun 7, 2024

+db

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

@cmsbuild ping

1 similar comment
@iarspider
Copy link
Contributor

@cmsbuild ping

@cmsbuild cmsbuild merged commit 3ed2913 into cms-sw:master Jun 12, 2024
17 checks passed
@francescobrivio francescobrivio deleted the alca_remove_volatile branch June 26, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants