Unprescaled AXO seeds (L1_AXO_Nominal, L1_AXO_VTight) added to the un… #45242
Conversation
…prescaled algo shortlist in L1TStage2uGTTiming config
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45242/40621
|
|
A new Pull Request was created by @jaisatul for master. It involves the following packages:
@syuvivida, @nothingface0, @tjavaid, @rvenditti, @antoniovagnerini, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| @@ -20,7 +20,9 @@ | |||
| "L1_SingleJet180", | |||
| "L1_ETMHF130", | |||
| "L1_HTT360er", | |||
| "L1_ETT2000" | |||
| "L1_ETT2000", | |||
| "L1_AXO_Nominal", | |||
There was a problem hiding this comment.
what about the other years before 2024?
Will we be flooded by more warning message? see #43488
There was a problem hiding this comment.
These seeds have been added in 2024 Menu. I tested with 2023 Runs and I get the warning that the Algo not found in the Trigger Menu
There was a problem hiding this comment.
precisely. What does the L1T DPG plan to do about these additional warnings?
There was a problem hiding this comment.
Hi @mmusich , I think the easiest way for this would be if we had year based eras in Run 3. In the meanwhile I think modifying the code to remove this warning message is ok. Atul said that the plots already omit the non-existing seeds, so there might be no reason to keep this warning in place. We'll have a look and provide a fix for these messages soon.
There was a problem hiding this comment.
@mmusich , thanks! I wasn't aware of this. We should definitely add this to the config, but in the meanwhile we can still suppress the warning message if we added one of these seeds in the middle of a year.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45242/40673
|
|
Pull request #45242 was updated. @cmsbuild, @syuvivida, @nothingface0, @rvenditti, @antoniovagnerini, @tjavaid can you please check and sign again. |
jaisatul
force-pushed
the
onlinedqmdev-addAXOSeedsTouGTAlgoAcceptPlots
branch
from
dc69ffc
to
a6fdd92
Compare
|
please test |
|
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
@tjavaid, Yes I will create a backport PR for 14_0_X soon |
|
Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X. |
|
+1 |
Two Unprescaled AXO seeds, L1_AXO_Nominal and L1_AXO_VTight, added to unprescaled uGT algo shortlist. This aims to add these seeds to uGT algo accept vs BX plots (L1T Online shift plots 19-20).