Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in TauMCEmbedding related to missing Pixel Cluster Shape #45288

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

stahlleiton
Copy link
Contributor

@stahlleiton stahlleiton commented Jun 24, 2024

PR description:

This PR disables the use of pixel cluster shape in DeDxHitInfoProducer in the TauMCEmbedding workflows. This addresses the issue raised in #45016 (comment) .

The use of the SiPixelClusterShape was recently introduced in #45016 and thus, was not used by the TauMCEmbedding workflows so far, so this PR should not affect the TauMCEmbedding (since the information gathered from the SiPixelClusterShape in DeDxHitInfoProducer is currently only used in the dEdxLikelihoodFit estimator ran in the Run3 UPC era).

PR validation:

Tested on relvals 136.901, 136.902, 136.903 and 136.904.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45288/40688

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

  • RecoTracker/DeDx (reconstruction)
  • TauAnalysis/MCEmbeddingTools (simulation)

@mdhildreth, @mandrenguyen, @cmsbuild, @jfernan2, @civanch can you please review it and eventually sign? Thanks.
@mmusich, @JanFSchulte, @gpetruc, @rovere, @felicepantaleo, @GiacomoSguazzoni, @mtosi, @VinInn, @VourMa, @missirol, @dgulhan this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jun 24, 2024

@harrypuuter since you introduced the workflows touched here can you please comment if this is an adequate fix?

@mmusich
Copy link
Contributor

mmusich commented Jun 24, 2024

test parameters:

  • workflows = 136.901, 136.902, 136.903, 136.904

@mmusich
Copy link
Contributor

mmusich commented Jun 24, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-602a1d/40047/summary.html
COMMIT: bf88ca7
CMSSW: CMSSW_14_1_X_2024-06-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45288/40047/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
136.901 step 7
136.902 step 7
136.903 step 7
136.904 step 7
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 3 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3451610
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3451587
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 234 log files, 194 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Jun 25, 2024

urgent

  • fixes IB failures

@mandrenguyen
Copy link
Contributor

+1

@stahlleiton
Copy link
Contributor Author

@cms-sw/simulation-l2 : please review/sign this PR , thanks

@civanch
Copy link
Contributor

civanch commented Jun 26, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 84c4df9 into cms-sw:master Jun 26, 2024
12 checks passed
@stahlleiton stahlleiton deleted the dEdx_CMSSW_14_1_X branch August 17, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants