-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue in TauMCEmbedding related to missing Pixel Cluster Shape #45288
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45288/40688
|
A new Pull Request was created by @stahlleiton for master. It involves the following packages:
@mdhildreth, @mandrenguyen, @cmsbuild, @jfernan2, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@harrypuuter since you introduced the workflows touched here can you please comment if this is an adequate fix? |
test parameters:
|
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-602a1d/40047/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
urgent
|
+1 |
@cms-sw/simulation-l2 : please review/sign this PR , thanks |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR disables the use of pixel cluster shape in DeDxHitInfoProducer in the TauMCEmbedding workflows. This addresses the issue raised in #45016 (comment) .
The use of the SiPixelClusterShape was recently introduced in #45016 and thus, was not used by the TauMCEmbedding workflows so far, so this PR should not affect the TauMCEmbedding (since the information gathered from the SiPixelClusterShape in DeDxHitInfoProducer is currently only used in the dEdxLikelihoodFit estimator ran in the Run3 UPC era).
PR validation:
Tested on relvals 136.901, 136.902, 136.903 and 136.904.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: