Updates to include HTMHF triggers in GT emulator #45295

elfontan · 2024-06-24T22:38:32Z

PR description:

This PR includes updates to include HTMHF triggers in GT emulator for the version 2024_v1_3_0 of the L1 menu (end of 2024 pp data-taking), as detailed in the following:

Inclusion of HTMHF object type in ESum in the GT data formats
Updates of the TriggerMenuParser to properly parse the new condition from the xml menu (according to new utm libraries utm_0.13.0: see code and documentation).
Propagation of the HTMHF trigger implementation to EnergySum condition (and correlations)
Propagation of the type definition changes to DataFormats/HLTReco and HLTL1TSeed module

PR validation:

The PR has been prepared starting from CMSSW_14_1_X_2024-06-23-0000:

cmsrel CMSSW_14_1_X_2024-06-23-0000
cd CMSSW_14_1_X_2024-06-23-0000/src
cmsenv
git cms-init
git cms-addpkg L1Trigger/L1TGlobal
git cms-addpkg DataFormats/L1TGlobal
git cms-addpkg DataFormats/HLTReco
git cms-addpkg HLTrigger/HLTfilters
scram b && scram b code-checks && scram b code-format && scram b

Test vectors have been produced by running the GT emulator standalone on a single orbit (3564 events) of EphemeralHLTPhysics 2024E (run 381065). Counts from the newly integrated triggers L1_MHTHF* in L1Menu_Collisions2024_v1_3_0 are obseved:

L1 seeds	Counts
L1_MHTHF100	179
L1_MHTHF120	99
L1_MHTHF125	86
L1_MHTHF130	72
L1_MHTHF150	44

Backport:

Backport to CMSSW_14_0_X needed by the time of the deployment of the next L1+HLT menus: #45356.

[cc: @eyigitba @slaurila @caruta @cavana @nabrandman ]

cmsbuild · 2024-06-24T22:38:59Z

cms-bot internal usage

cmsbuild · 2024-06-24T22:45:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45295/40699

This PR adds an extra 72KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/L1TGlobal/interface/GlobalDefinitions.h modified in PR(s): CICADA-uGT emulator additions #44222
- File L1Trigger/L1TGlobal/plugins/TriggerMenuParser.cc modified in PR(s): CICADA-uGT emulator additions #44222
- File L1Trigger/L1TGlobal/src/GlobalDefinitions.cc modified in PR(s): CICADA-uGT emulator additions #44222

cmsbuild · 2024-06-24T22:45:43Z

A new Pull Request was created by @elfontan for master.

It involves the following packages:

DataFormats/L1TGlobal (l1)
L1Trigger/L1TGlobal (l1)

@cmsbuild, @aloeliger, @epalencia can you please review it and eventually sign? Thanks.
@rovere, @missirol, @Martin-Grunewald, @mmusich this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

…include muon showers)

cmsbuild · 2024-06-24T23:00:31Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45295/40700

This PR adds an extra 76KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/L1TGlobal/interface/GlobalDefinitions.h modified in PR(s): CICADA-uGT emulator additions #44222
- File L1Trigger/L1TGlobal/plugins/TriggerMenuParser.cc modified in PR(s): CICADA-uGT emulator additions #44222
- File L1Trigger/L1TGlobal/src/GlobalDefinitions.cc modified in PR(s): CICADA-uGT emulator additions #44222

cmsbuild · 2024-06-24T23:00:55Z

Pull request #45295 was updated. @aloeliger, @cmsbuild, @epalencia can you please check and sign again.

epalencia · 2024-06-25T06:02:12Z

Please test

missirol

Looking at downstream classes, I would say that HLTL1TSeed and TriggerTypeDefs also need to be updated in order to support the new HTMHF objects. @cms-sw/hlt-l2

DataFormats/L1TGlobal/interface/GlobalObject.h

DataFormats/L1TGlobal/test/test_catch2_l1tGlobalObject.cc

cmsbuild · 2024-06-25T09:59:53Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26c8b1/40057/summary.html
COMMIT: ccac021
CMSSW: CMSSW_14_1_X_2024-06-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45295/40057/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3345088
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3345065
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

mmusich · 2024-06-25T10:57:28Z

assign hlt

cmsbuild · 2024-06-25T10:57:52Z

New categories assigned: hlt

@Martin-Grunewald,@mmusich you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild · 2024-06-26T16:22:31Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26c8b1/40087/summary.html
COMMIT: d578742
CMSSW: CMSSW_14_1_X_2024-06-26-1200/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45295/40087/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 4 errors in the following unit tests:

---> test testTauEmbeddingWorkflow2016preVFP had ERRORS
---> test testTauEmbeddingWorkflow2016postVFP had ERRORS
---> test testTauEmbeddingWorkflow2017 had ERRORS
and more ...

Comparison Summary

Summary:

You potentially removed 4 lines from the logs
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3345088
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3345068
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

mmusich · 2024-06-27T06:40:54Z

-1

still unrelated failures, will be fixed by #45288

mmusich · 2024-06-27T12:02:28Z

@cmsbuild, please test

cmsbuild · 2024-06-27T16:35:02Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26c8b1/40120/summary.html
COMMIT: d578742
CMSSW: CMSSW_14_1_X_2024-06-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45295/40120/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3345088
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3345065
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

elfontan · 2024-06-28T15:12:35Z

@elfontan

One more comment. Maybe it's beyond the scope of this PR, but it seems to me that the new "HTMHF" object may need to be propagated downstream in a few places for DQM and NanoAOD.

Examples.
* https://github.com/cms-sw/cmssw/blob/c0b15502e530da86f3fada015ba93ccd5ece93e3/DQMOffline/L1Trigger/src/L1TStage2CaloLayer2Offline.cc#L242-L262

* https://github.com/cms-sw/cmssw/blob/c0b15502e530da86f3fada015ba93ccd5ece93e3/PhysicsTools/NanoAOD/plugins/TriggerObjectTableProducer.cc#L234-L237
Actually, in the NanoAOD part (e.g.

cmssw/PhysicsTools/NanoAOD/plugins/TriggerObjectTableProducer.cc

Lines 204 to 207 in c0b1550

case l1t::EtSum::EtSumType::kMissingEtHF:

l1obj.addTriggerObjectType(trigger::TriggerL1ETM);

l1obj.setCollection("L1ETMHF");

break;

), I do not understand why TriggerL1ETM is being used for "L1ETMHF". Naively it should be TriggerL1ETMHF, but maybe I'm missing something.

Hi @missirol thank you for your point!
I personally believe that this can be kept in mind by the L1 group (@epalencia @aloeliger @eyigitba @slaurila) as later update and is not essential to move on with this update, for now. (=> July 23, 2024: follow up in github issue #45538).
But I let them comment more on this.

I wait for further feedback to proceed with a backport of the changes to CMSSW_14_0_X.

Cheers,
--Elisa

slaurila · 2024-06-30T19:58:01Z

@elfontan
One more comment. Maybe it's beyond the scope of this PR, but it seems to me that the new "HTMHF" object may need to be propagated downstream in a few places for DQM and NanoAOD.
Examples.
* https://github.com/cms-sw/cmssw/blob/c0b15502e530da86f3fada015ba93ccd5ece93e3/DQMOffline/L1Trigger/src/L1TStage2CaloLayer2Offline.cc#L242-L262

* https://github.com/cms-sw/cmssw/blob/c0b15502e530da86f3fada015ba93ccd5ece93e3/PhysicsTools/NanoAOD/plugins/TriggerObjectTableProducer.cc#L234-L237
Actually, in the NanoAOD part (e.g.

cmssw/PhysicsTools/NanoAOD/plugins/TriggerObjectTableProducer.cc

Lines 204 to 207 in c0b1550

case l1t::EtSum::EtSumType::kMissingEtHF:

l1obj.addTriggerObjectType(trigger::TriggerL1ETM);

l1obj.setCollection("L1ETMHF");

break;

), I do not understand why TriggerL1ETM is being used for "L1ETMHF". Naively it should be TriggerL1ETMHF, but maybe I'm missing something.
Hi @missirol thank you for your point! I personally believe that this can be kept in mind by the L1 group (@epalencia @aloeliger @eyigitba @slaurila) as later update and is not essential to move on with this update, for now. (We could maybe open a github issue to keep track?) But I let them comment more on this.

I wait for further feedback to proceed with a backport of the changes to CMSSW_14_0_X.

Cheers, --Elisa

Hi, in the interest of time, I'd suggest we proceed with this PR and the backport ASAP (to enable the HLT menu development), and save the DQM and Nano updates for separate PRs that can follow later. @epalencia @aloeliger can you please comment if you also think this is fine, i.e. nothing breaks in L1 Nano or DQM even if we don't update them right now.

Thanks!
Santeri

aloeliger · 2024-07-01T09:07:17Z

@elfontan
One more comment. Maybe it's beyond the scope of this PR, but it seems to me that the new "HTMHF" object may need to be propagated downstream in a few places for DQM and NanoAOD.
Examples.
* https://github.com/cms-sw/cmssw/blob/c0b15502e530da86f3fada015ba93ccd5ece93e3/DQMOffline/L1Trigger/src/L1TStage2CaloLayer2Offline.cc#L242-L262

* https://github.com/cms-sw/cmssw/blob/c0b15502e530da86f3fada015ba93ccd5ece93e3/PhysicsTools/NanoAOD/plugins/TriggerObjectTableProducer.cc#L234-L237
Actually, in the NanoAOD part (e.g.

cmssw/PhysicsTools/NanoAOD/plugins/TriggerObjectTableProducer.cc

Lines 204 to 207 in c0b1550

case l1t::EtSum::EtSumType::kMissingEtHF:

l1obj.addTriggerObjectType(trigger::TriggerL1ETM);

l1obj.setCollection("L1ETMHF");

break;

), I do not understand why TriggerL1ETM is being used for "L1ETMHF". Naively it should be TriggerL1ETMHF, but maybe I'm missing something.
Hi @missirol thank you for your point! I personally believe that this can be kept in mind by the L1 group (@epalencia @aloeliger @eyigitba @slaurila) as later update and is not essential to move on with this update, for now. (We could maybe open a github issue to keep track?) But I let them comment more on this.
I wait for further feedback to proceed with a backport of the changes to CMSSW_14_0_X.
Cheers, --Elisa
Hi, in the interest of time, I'd suggest we proceed with this PR and the backport ASAP (to enable the HLT menu development), and save the DQM and Nano updates for separate PRs that can follow later. @epalencia @aloeliger can you please comment if you also think this is fine, i.e. nothing breaks in L1 Nano or DQM even if we don't update them right now.

Thanks! Santeri

@slaurila in the interest of making the HLT deadline, I think this is fine with me

aloeliger · 2024-07-01T09:08:07Z

+l1

Martin-Grunewald · 2024-07-01T10:59:23Z

@elfontan
Please prepare the PR to backport this to 14_0. Thanks!

Martin-Grunewald · 2024-07-01T10:59:28Z

+1

cmsbuild · 2024-07-01T10:59:50Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

mmusich · 2024-07-01T11:11:13Z

@elfontan @slaurila @eyigitba please open a backport ASAP.

rappoccio · 2024-07-01T15:44:09Z

+1

Updates to include HTMHF triggers in GT emulator

184d632

cmsbuild added this to the CMSSW_14_1_X milestone Jun 24, 2024

cmsbuild added l1-pending pending-signatures tests-pending orp-pending code-checks-pending labels Jun 24, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 24, 2024

Updates to include HTMHF triggers in GT emulator (minor bug fix to re…

ccac021

…include muon showers)

cmsbuild added code-checks-pending and removed code-checks-approved labels Jun 24, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 24, 2024

cmsbuild added tests-started and removed tests-pending labels Jun 25, 2024

missirol reviewed Jun 25, 2024

View reviewed changes

DataFormats/L1TGlobal/interface/GlobalObject.h Outdated Show resolved Hide resolved

DataFormats/L1TGlobal/interface/GlobalObject.h Outdated Show resolved Hide resolved

DataFormats/L1TGlobal/test/test_catch2_l1tGlobalObject.cc Outdated Show resolved Hide resolved

cmsbuild mentioned this pull request Jun 25, 2024

CICADA-uGT emulator additions #44222

Merged

cmsbuild added tests-approved and removed tests-started labels Jun 25, 2024

cmsbuild added the hlt-pending label Jun 25, 2024

cmsbuild added tests-rejected and removed tests-started labels Jun 26, 2024

cmsbuild added tests-started and removed tests-rejected labels Jun 27, 2024

cmsbuild added tests-approved and removed tests-started labels Jun 27, 2024

cmsbuild added l1-approved and removed l1-pending labels Jul 1, 2024

cmsbuild added hlt-approved fully-signed and removed hlt-pending pending-signatures labels Jul 1, 2024

cmsbuild added orp-approved and removed orp-pending labels Jul 1, 2024

cmsbuild merged commit f1a5ed3 into cms-sw:master Jul 1, 2024
11 checks passed

elfontan mentioned this pull request Jul 1, 2024

Updates to include HTMHF triggers in GT emulator and propagation to HLTL1Seed #45356

Merged

elfontan mentioned this pull request Jul 23, 2024

[L1T] Propagating updates for HTMHF object to DQM and NanoAOD #45538

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates to include HTMHF triggers in GT emulator #45295

Updates to include HTMHF triggers in GT emulator #45295

elfontan commented Jun 24, 2024 •

edited

Loading

cmsbuild commented Jun 24, 2024 •

edited

Loading

cmsbuild commented Jun 24, 2024

cmsbuild commented Jun 24, 2024

cmsbuild commented Jun 24, 2024

cmsbuild commented Jun 24, 2024

epalencia commented Jun 25, 2024

missirol left a comment

cmsbuild commented Jun 25, 2024

mmusich commented Jun 25, 2024

cmsbuild commented Jun 25, 2024

cmsbuild commented Jun 26, 2024

mmusich commented Jun 27, 2024

mmusich commented Jun 27, 2024

cmsbuild commented Jun 27, 2024

elfontan commented Jun 28, 2024 •

edited

Loading

slaurila commented Jun 30, 2024

aloeliger commented Jul 1, 2024

aloeliger commented Jul 1, 2024

Martin-Grunewald commented Jul 1, 2024

Martin-Grunewald commented Jul 1, 2024

cmsbuild commented Jul 1, 2024

mmusich commented Jul 1, 2024

rappoccio commented Jul 1, 2024

Updates to include HTMHF triggers in GT emulator #45295

Updates to include HTMHF triggers in GT emulator #45295

Conversation

elfontan commented Jun 24, 2024 • edited Loading

PR description:

PR validation:

Backport:

cmsbuild commented Jun 24, 2024 • edited Loading

cmsbuild commented Jun 24, 2024

cmsbuild commented Jun 24, 2024

cmsbuild commented Jun 24, 2024

cmsbuild commented Jun 24, 2024

epalencia commented Jun 25, 2024

missirol left a comment

Choose a reason for hiding this comment

cmsbuild commented Jun 25, 2024

Comparison Summary

mmusich commented Jun 25, 2024

cmsbuild commented Jun 25, 2024

cmsbuild commented Jun 26, 2024

Unit Tests

Comparison Summary

mmusich commented Jun 27, 2024

mmusich commented Jun 27, 2024

cmsbuild commented Jun 27, 2024

Comparison Summary

elfontan commented Jun 28, 2024 • edited Loading

slaurila commented Jun 30, 2024

aloeliger commented Jul 1, 2024

aloeliger commented Jul 1, 2024

Martin-Grunewald commented Jul 1, 2024

Martin-Grunewald commented Jul 1, 2024

cmsbuild commented Jul 1, 2024

mmusich commented Jul 1, 2024

rappoccio commented Jul 1, 2024

elfontan commented Jun 24, 2024 •

edited

Loading

cmsbuild commented Jun 24, 2024 •

edited

Loading

elfontan commented Jun 28, 2024 •

edited

Loading