MTD geometry: fix RecoMTD/DetLayers unit test

[fabiocos]

PR description:

As a consequence of the move of all MTD geometry unit tests to scenario D110 in #45211 , the unit test for the tracking geometry navigation in RecoMTD/DetLayers starts to fail on aarch64 architecture #45211 (comment) , due to some numerical differences in the output of operations displayed in the reference file.

The underlying geometry calculations are made using float for performance reasons, and on operations involving space measurements of a size O(100 cm) does not always guarantee to display identical results at the micron level on both amd64 and aarch64. For this reason:

• a better formatting and rounding is adopted in this test, with a configurable precision;
• a 4 decimal digits precision is kept for direct inspection, but a safer 2 digits precision is used in the unit test (and corresponding reference, that needs to be updated in parallel to this PR)

PR validation:

The unit test comparison succeed on both amd64 and aarch64 (lxplus-arm.cern.ch).

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45310/40724

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

• RecoMTD/DetLayers (upgrade, reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test with cms-data/Geometry-TestReference#15

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a4ff4/40083/summary.html
COMMIT: a6c1431
CMSSW: CMSSW_14_1_X_2024-06-26-1200/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45310/40083/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially added 14 lines to the logs
• Reco comparison results: 13 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345088
• DQMHistoTests: Total failures: 847
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3344221
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[fabiocos]

please test with cms-data/Geometry-TestReference#15 for el8_aarch64_gcc12

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a4ff4/40103/summary.html
COMMIT: a6c1431
CMSSW: CMSSW_14_1_X_2024-06-25-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45310/40103/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw Revert "Add Unpacker for L1T Calo Layer 1 to unpack CICADA" #45308
• @cms-sw added as needed IBs overrides cmsdist#9267

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a4ff4/40103/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a4ff4/40103/git-merge-result

[mandrenguyen]

type mtd

[mandrenguyen]

+1

[fabiocos]

@cms-sw/upgrade-l2 @cms-sw/orp-l2 this PR (and the corresponding cms-data/Geometry-TestReference#15 ) will prevent the unit test crash in IB observed for aarch64 architecture, reported by @aandvalenzuela

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/Geometry-TestReference#15

[antoniovilela]

cms-data/Geometry-TestReference#15 merged.
cmsdist tag PR: cms-sw/cmsdist#9274.

[antoniovilela]

+1