Revert "Add Unpacker for L1T Calo Layer 1 to unpack CICADA"

[smuzaffar]

Reverts #45037

A re-revert will be needed to go with #44222

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45308/40718

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• EventFilter/L1TRawToDigi (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @eyigitba, @missirol, @mmusich, @thomreis this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[aloeliger]

+l1

in case that matters.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

thanks @aloeliger , I will merge it before 11h00.
I can open a re-revert of this but then you might not be able to provide any changes there (if needed). Do you prefer to open a re-revert yourself or may be add re-revert changes directly in #44222 ?

[aloeliger]

@smuzaffar I think the simplest would just be to package it together with #44222, but it gets ever so slightly worse, because there are backports open as #45293 & #45294, so I don't know what's preferable from a history-of-cmssw perspective and the versioning. I can manipulate the commits as needed to get @fwyzard's simplifications in the proper places, it's just whatever you think would be most organized.

[smuzaffar]

@cms-sw/orp-l2 , I am merging this for 11h00 IB now. Build errors are fixed, unit tests and add-on tests have run successfully.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e9025/40082/summary.html
COMMIT: 6c6a847
CMSSW: CMSSW_14_1_X_2024-06-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45308/40082/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

There are some workflows for which there are errors in the baseline:
1000.0 step 2
1001.0 step 2
10224.0 step 2
11634.0 step 2
12434.0 step 2
12834.0 step 2
12834.7 step 2
12846.0 step 2
13034.0 step 2
1306.0 step 2
13234.0 step 2
1330.0 step 2
135.4 step 1
136.731 step 2
136.793 step 2
136.874 step 2
139.001 step 2
140.023 step 2
140.043 step 2
140.063 step 2
140.56 step 2
14034.0 step 2
141.042 step 2
141.044 step 2
141.046 step 2
14234.0 step 2
23234.0 step 2
25.0 step 3
250202.181 step 3
25202.0 step 2
29634.0 step 2
29634.911 step 2
29696.0 step 2
29700.0 step 2
29834.999 step 3
312.0 step 2
4.53 step 3
9.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 3242 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 9
• DQMHistoTests: Total histograms compared: 105339
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 105335
• DQMHistoTests: Total skipped: 4
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 8 files compared)
• Checked 108 log files, 40 edm output root files, 9 DQM output files
• TriggerResults: no differences found