Fix duplication of TrigObj in nanoAOD

[BlancoFS]

PR description:

Remove the pT matching requirement in the TrigObj self-cleaning to allow objects with slightly different pT enter the cleaning.

This PR is made after observing that most of the muons with pT>100 GeV are duplicated, or tripled, as TrigObj. This occurs because of the redundant reconstruction for Muons above 100 GeV (highPtTkMu, MuCascade, ...).

This issue was presented in the following XPOG meeting, where this solution was proposed.

As a further check, we tested other objects that may be affected by this change (possible duplicates):

• Muons (Main target)
• Tau
• FatJet
• HT
• MHT

Alternatively, if this solution affect in any negative way other objects than Muons, we propose to modify the IF condition such that the pT matching is bypass only for Muon IDs

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46072/41862

[cmsbuild]

A new Pull Request was created by @BlancoFS for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[hqucms]

enable nano

[hqucms]

please test

[hqucms]

@cms-sw/tau-pog-l2 @cms-sw/jetmet-pog-l2 @cms-sw/egamma-pog-l2 Could you please check and comment if the propose change is OK for you? Thanks a lot!

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-051be6/41664/summary.html
COMMIT: c7f0ace
CMSSW: CMSSW_14_2_X_2024-09-20-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46072/41664/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 83 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331158
• DQMHistoTests: Total failures: 4840
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3326298
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially added 688 lines to the logs
• Reco comparison results: 187 differences found in the comparisons
• DQMHistoTests: Total files compared: 21
• DQMHistoTests: Total histograms compared: 55132
• DQMHistoTests: Total failures: 668
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 54464
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
• Checked 102 log files, 58 edm output root files, 21 DQM output files
• TriggerResults: no differences found

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.001	2.839	2.841	-0.002 ( -0.1% )	3.11	3.06	+1.8%	6.043	6.056
2500.002	2.951	2.955	-0.004 ( -0.1% )	2.77	2.71	+2.1%	6.402	6.461
2500.003	2.897	2.901	-0.004 ( -0.2% )	2.89	2.87	+0.8%	6.419	6.373
2500.011	1.493	1.493	0.000 ( +0.0% )	4.76	4.73	+0.6%	2.113	2.407
2500.012	1.958	1.959	-0.001 ( -0.1% )	2.88	2.88	-0.0%	2.155	2.602
2500.013	1.809	1.809	-0.000 ( -0.0% )	4.12	4.08	+0.9%	1.978	2.504
2500.021	0.022	0.022	0.000 ( +0.0% )	0.96	0.92	+4.7%	2.126	2.383
2500.022	0.022	0.022	0.000 ( +0.0% )	0.92	0.86	+7.7%	2.117	2.374
2500.023	0.022	0.022	0.000 ( +0.0% )	0.91	0.90	+1.0%	1.970	2.253
2500.024	0.022	0.022	0.000 ( +0.0% )	0.69	0.67	+2.3%	2.217	2.466
2500.031	0.035	0.035	0.000 ( +0.0% )	0.86	0.85	+0.7%	2.130	2.436
2500.032	0.036	0.036	0.000 ( +0.0% )	0.87	0.87	+0.2%	2.109	2.408
2500.033	0.037	0.037	0.000 ( +0.0% )	0.78	0.77	+1.3%	2.184	2.481
2500.034	0.036	0.036	0.000 ( +0.0% )	0.80	0.79	+1.0%	2.166	2.460
2500.101	2.654	2.660	-0.006 ( -0.2% )	8.87	8.69	+2.1%	6.326	6.328
2500.111	1.340	1.342	-0.002 ( -0.1% )	18.83	18.56	+1.5%	2.206	2.225
2500.112	1.747	1.749	-0.002 ( -0.1% )	14.17	13.23	+7.1%	2.305	2.304
2500.131	0.747	0.747	0.000 ( +0.0% )	18.38	18.08	+1.7%	1.499	1.480
2500.201	2.485	2.490	-0.006 ( -0.2% )	7.53	7.15	+5.4%	5.605	5.606
2500.211	1.611	1.612	-0.001 ( -0.1% )	17.96	17.64	+1.8%	2.280	2.278
2500.212	2.054	2.055	-0.001 ( -0.0% )	14.42	14.20	+1.6%	2.359	2.360
2500.221	1.997	2.003	-0.006 ( -0.3% )	7.81	7.84	-0.4%	2.447	2.444
2500.222	3.216	3.222	-0.006 ( -0.2% )	7.58	7.48	+1.4%	2.531	2.534
2500.223	8.904	8.909	-0.006 ( -0.1% )	2.68	2.62	+2.5%	2.557	2.562
2500.224	5.675	5.680	-0.006 ( -0.1% )	0.60	0.60	+0.4%	2.206	2.171
2500.225	5.692	5.698	-0.006 ( -0.1% )	0.58	0.58	+0.3%	2.222	2.170
2500.226	2.982	2.988	-0.006 ( -0.2% )	7.64	7.46	+2.4%	2.527	2.530
2500.227	1.437	1.437	0.000 ( +0.0% )	11.87	11.57	+2.6%	1.437	1.430
2500.231	1.403	1.403	-0.001 ( -0.1% )	14.33	14.13	+1.4%	2.179	2.180
2500.232	2.259	2.260	-0.001 ( -0.0% )	14.08	13.76	+2.3%	2.266	1.998
2500.233	4.706	4.707	-0.001 ( -0.0% )	4.32	4.17	+3.5%	2.284	2.018
2500.234	3.414	3.415	-0.001 ( -0.0% )	0.76	0.76	+0.2%	2.055	1.770
2500.235	3.425	3.426	-0.001 ( -0.0% )	0.74	0.74	+0.2%	2.083	2.083
2500.236	2.106	2.107	-0.001 ( -0.0% )	13.68	14.09	-2.9%	1.996	2.269
2500.237	1.016	1.016	0.000 ( +0.0% )	17.21	17.05	+0.9%	1.159	1.445
2500.241	9.404	9.404	0.000 ( +0.0% )	3.74	3.66	+2.1%	1.932	1.946
2500.242	10.331	10.331	0.000 ( +0.0% )	0.90	0.88	+3.3%	1.734	1.734
2500.243	2.712	2.712	0.000 ( +0.0% )	8.80	7.10	+24.0%	1.077	1.078
2500.244	485.976	485.976	0.000 ( +0.0% )	0.57	0.56	+2.8%	1.688	1.698
2500.245	823.202	823.202	0.000 ( +0.0% )	0.76	0.73	+4.3%	1.676	1.658
2500.901	1.777	1.777	0.000 ( +0.0% )	20.61	20.88	-1.3%	1.843	1.601
2500.902	1.626	1.626	0.000 ( +0.0% )	20.67	21.32	-3.0%	1.770	1.768
2500.911	13.995	13.995	0.000 ( +0.0% )	3.10	3.77	-17.8%	1.100	1.092
2500.912	0.438	0.437	0.002 ( +0.4% )	1.50	1.29	+16.4%	0.968	0.969
2500.913	0.110	0.110	0.000 ( +0.0% )	1.15	1.13	+1.4%	0.974	0.973

[afiqaize]

EGM TrigObjs are unaffected, and so this is ok for us. Thanks.

@cms-sw/egamma-pog-l2

[brallmond]

The Tau TrigObjs are also unaffected, from looking at the logs in this thread. Ok for us.

@cms-sw/tau-pog-l2

[hqucms]

@cms-sw/jetmet-pog-l2 Could you please have a look and confirm on this?

[nurfikri89]

@cms-sw/jetmet-pog-l2 Could you please have a look and confirm on this?

@hqucms For JetMET, the TrigObjs are not affected. It is okay for us.

[hqucms]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1