Improve constructor for PhotonIsolationCalculator

[Dr15Jones]

PR description:

It is in general better to use a constructor rather than a setup method.

PR validation:

Compiles.

[cmsbuild]

cms-bot internal usage

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46289/42111

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoEgamma/EgammaPhotonProducers/src/GEDPhotonProducer.cc modified in PR(s): Modernize RecoEgamma/PhotonIdentification helpers #46276
  • File RecoEgamma/EgammaPhotonProducers/src/PhotonProducer.cc modified in PR(s): Modernize RecoEgamma/PhotonIdentification helpers #46276
  • File RecoEgamma/PhotonIdentification/src/PhotonIsolationCalculator.cc modified in PR(s): Pass pointer to EgammaRecHitIsolation::getEtSum #46271

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• RecoEgamma/EgammaPhotonProducers (reconstruction)
• RecoEgamma/PhotonIdentification (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@Prasant1993, @Sam-Harper, @a-kapoor, @afiqaize, @jainshilpi, @lgray, @missirol, @ram1123, @rovere, @sameasy, @sobhatta, @valsdav, @varuns23 this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cb0ee1/42025/summary.html
COMMIT: 3e9d291
CMSSW: CMSSW_14_2_X_2024-10-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46289/42025/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 44 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331336
• DQMHistoTests: Total failures: 3445
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3327871
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[makortel]

After the merge of #46276 there is a conflict

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46289/42115

[cmsbuild]

Pull request #46289 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46289/42116

[cmsbuild]

Pull request #46289 was updated. @jfernan2, @mandrenguyen can you please check and sign again.

[cmsbuild]

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cb0ee1/42032/summary.html
COMMIT: 228bf6e
CMSSW: CMSSW_14_2_X_2024-10-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46289/42032/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @BlancoFS Fix duplication of TrigObj in nanoAOD #46072
• @mmusich Miscellaneous fixes for HLT online DQM  #46245
• @iarspider [DQM] Fix syntax in python scripts #46166
• @Dr15Jones Pass pointer to EgammaRecHitIsolation::getEtSum #46271
• @barvic DQM CSCMonitorModule: crash fix for corrupted events with missing ALCT data (14_2_X) #46257
• @smuzaffar [L1] Applying code checks/format #46217
• @iarspider [LLVM Analyzer][L1] Remove dead code #46270
• @mmusich Add standalone unit test for DQM/TrackingMonitorSource plugins #46187
• @smuzaffar [DQM] Applying code checks/format #46216
• @smuzaffar [GENERATORS] [PY312] String formatting to fix SyntaxWarning #46091
• @iarspider [LLVM Analyzer] Fix use-after-free in DQM/SiStripMonitorSummary/bin/makePlots.cc #46197
• @smuzaffar [GENERATORS] Applying code checks/format #46215
• @smuzaffar [DQM] [Clang]Cleanup clang-analyzer warnings #46227
• @smuzaffar [ClangAna][HcalHits] Remove dead code; suppress false-positive warnings #46225
• @smuzaffar Removed cmsScimark2 exec and scripts #46235
• @rdelliga MTD Validation: speed up LocalRecoValidation plus other fixes #46236
• @smuzaffar [L1] [Clang]Cleanup clang-analyzer warnings #46237
• @sroychow Increase threshold of max number of pixel clusters for cosmic tracking #46283
• @Dr15Jones Modernize RecoEgamma/PhotonIdentification helpers #46276
• @smuzaffar [DQM-GENERATORS] [Clang]Cleanup clang-analyzer warnings #46228

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cb0ee1/42032/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cb0ee1/42032/git-merge-result

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 37 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331066
• DQMHistoTests: Total failures: 3877
• DQMHistoTests: Total nulls: 14
• DQMHistoTests: Total successes: 3327155
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -86.45400000000001 KiB( 43 files compared)
• DQMHistoSizes: changed ( 24834.911,... ): -7.841 KiB MTD/BTL
• DQMHistoSizes: changed ( 24834.911,... ): -7.186 KiB MTD/ETL
• DQMHistoSizes: changed ( 24834.911,... ): 0.344 KiB MTD/Tracks
• DQMHistoSizes: changed ( 24834.911,... ): 0.273 KiB MTD/Vertices
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1