Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standalone unit test for DQM/TrackingMonitorSource plugins #46187

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 1, 2024

PR description:

Title says it all:

  • 27a84e6 add missing fillDescription parameters and place early returns in case of missing input data in various plugins
  • dcf5859 add catch2 based tests for various plugins in the package

PR validation:

scram b runtests_testTrackingDQMAnalyzers runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, might be backported

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

cms-bot internal usage

@mmusich mmusich changed the title Mm standalona track monitor tests Add standalone unit test for DQM/TrackingMonitorSource plugins Oct 1, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46187/41986

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/TrackingMonitorSource (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@JanFSchulte, @VinInn, @VourMa, @arossi83, @fioriNTU, @idebruyn, @jandrea, @mmusich, @mtosi, @sroychow, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 2, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2024

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9f4f7/41860/summary.html
COMMIT: dcf5859
CMSSW: CMSSW_14_2_X_2024-10-01-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46187/41860/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0bd935f into cms-sw:master Oct 7, 2024
11 checks passed
@mmusich mmusich deleted the mm_StandalonaTrackMonitor_tests branch October 7, 2024 09:07
@Dr15Jones
Copy link
Contributor

Nice! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants