Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.1.X] Miscellaneous backports to DQM/TrackingMonitorSource #46280

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 7, 2024

backport of #46005
backport of #46187

PR description:

  • 41e92bb make V0EventSelector produce skimmed V0 collections based on their mass. It was suggested to modify V0EventSelector in order to produce skimmed V0 collections based on their mass, to enhance the purity in terms of strange origin of the tracks analyzed via StandaloneTrackMonitor, based on the results shown here and here.
  • 199548d add missing fillDescription parameters and place early returns in case of missing input data in various plugins
  • 514a64c add catch2 based tests for various plugins in the package

This update concerns only the Tracking Data/MC validation suite and is of no consequence on any DQM production sequence run in online or offline DQM.

PR validation:

Relies on the unit tests of this package: (existing) scram b runtests_testTrackingDATAMC and (newly added) scram b runtests_testTrackingDQMAnalyzers both run fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backports of #46005 and #46187

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

A new Pull Request was created by @mmusich for CMSSW_14_1_X.

It involves the following packages:

  • DQM/TrackingMonitorSource (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@JanFSchulte, @VinInn, @VourMa, @arossi83, @fioriNTU, @idebruyn, @jandrea, @mmusich, @mtosi, @sroychow, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Oct 7, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91644d/42010/summary.html
COMMIT: 514a64c
CMSSW: CMSSW_14_1_X_2024-10-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46280/42010/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ee94214 into cms-sw:CMSSW_14_1_X Oct 9, 2024
9 checks passed
@mmusich mmusich deleted the mm_StandalonaTrackMonitor_tests_14_1_X branch October 9, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants