DQM CSCMonitorModule: crash fix for corrupted events with missing ALCT data (14_2_X)

[barvic]

PR description:

DQM CSCMonitorModule: crash fix for handling of corrupted events with missing/corrupted ALCT data
Fix for the issue "Segmentation violation in CSCMonitorModule during Express job at T0 #45797 "
#45797

PR validation:

Initial crash was reproduced with original code
After fix was applied the standard CMSSW checks passed
The fix was tested with provided data sample
/eos/user/c/cmst0/public/PausedJobs/Run2024G/dqmCSCClient/job_2218360/input/run384963_ls0707_streamExpress_StorageManager.dat
No crashes were observed.
Please advise if backports are needed

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46257/42080

[cmsbuild]

A new Pull Request was created by @barvic for master.

It involves the following packages:

• DQM/CSCMonitorModule (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@ptcox this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

Please advise if backports are needed

a 14.1.X backport would be useful.

[mmusich]

type csc

[mmusich]

type bug-fix

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4c8df/41988/summary.html
COMMIT: 4dfa9e3
CMSSW: CMSSW_14_2_X_2024-10-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46257/41988/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331336
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3331316
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[vlimant]

urgent

[vicha-w]

Hi @barvic @mmusich @vlimant,

This PR has been tested on DQM playback machine with 14_0_15_patch1 and run 386478. All clients ended gracefully.

For more information please refer to DQM^2 mirror logs here: https://cmsweb.cern.ch/dqm/dqm-square/?run=519509&db=playback

Best regards,
Vichayanun

[antoniovagnerini]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1