Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store/v2): Merge Feature Branch #18150

Merged
merged 52 commits into from
Oct 18, 2023
Merged

feat(store/v2): Merge Feature Branch #18150

merged 52 commits into from
Oct 18, 2023

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Oct 17, 2023

Description

This PR merges the current feature branch of the latest Store v2 work into main. We will create a release branch for the current Store v1 line in case backports need to be made.

Note to reviewers: Majority of the changes in this branch have already been reviewed! By all means feel free to evaluate the diff, but do not feel pressured to evaluate everything.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@@ -0,0 +1,15 @@
# tracekv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this related to state streaming? it seems they overlap in use cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, it's not. In store v1 there was listenkv (no longer exists) and tracekv (ported to v2). tracekv is useful for directly plugging into an io.writer to evaluate R/W on stores.

I think state streaming is more sophisticated and heavy. There you're piping state changes to some external sink.

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left minor tidbits but they are all follow ups, added them to the epic. small things

@alexanderbez alexanderbez added this pull request to the merge queue Oct 18, 2023
Merged via the queue into main with commit 03bca7b Oct 18, 2023
61 of 62 checks passed
@alexanderbez alexanderbez deleted the feature/store-v2 branch October 18, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants