-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store/v2): Merge Feature Branch #18150
Conversation
@@ -0,0 +1,15 @@ | |||
# tracekv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this related to state streaming? it seems they overlap in use cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, it's not. In store v1 there was listenkv
(no longer exists) and tracekv
(ported to v2). tracekv
is useful for directly plugging into an io.writer
to evaluate R/W on stores.
I think state streaming is more sophisticated and heavy. There you're piping state changes to some external sink.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left minor tidbits but they are all follow ups, added them to the epic. small things
Description
This PR merges the current feature branch of the latest Store v2 work into
main
. We will create a release branch for the current Store v1 line in case backports need to be made.Note to reviewers: Majority of the changes in this branch have already been reviewed! By all means feel free to evaluate the diff, but do not feel pressured to evaluate everything.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change