implement --offline flag #5810

jgimeno · 2020-03-16T18:05:34Z

Closes: #5448

Description

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

codecov · 2020-03-16T18:38:32Z

Codecov Report

Merging #5810 into master will decrease coverage by 0.2%.
The diff coverage is 31.25%.

@@            Coverage Diff            @@
##           master   #5810      +/-   ##
=========================================
- Coverage   32.51%   32.3%   -0.21%     
=========================================
  Files         346     353       +7     
  Lines       39012   39461     +449     
=========================================
+ Hits        12684   12749      +65     
- Misses      25061   25439     +378     
- Partials     1267    1273       +6

Impacted Files	Coverage Δ
x/auth/client/cli/tx_sign.go	`0% <0%> (ø)`
x/distribution/client/cli/tx.go	`4.7% <0%> (ø)`	⬆️
x/auth/client/cli/tx_multisign.go	`0% <0%> (ø)`
x/auth/client/tx.go	`14.64% <0%> (ø)`	⬆️
client/context/query.go	`1.86% <0%> (ø)`	⬆️
x/auth/client/cli/broadcast.go	`84% <100%> (ø)`
client/context/context.go	`32.86% <75%> (+30.73%)`	⬆️
x/auth/client/cli/encode.go	`0% <0%> (ø)`
... and 5 more

client/context/context.go

alessio

Good start! I'd love some test cases - at least to avoid code coverage to get even lower. Plus, all query commands should all fail if --offline is passed

alexanderbez

Looks great @jgimeno! Let's get a branch open against Gaia that tests this out.

client/context/context.go

CHANGELOG.md

client/flags/flags.go

x/auth/client/cli/broadcast.go

Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>

client/context/context.go

…m:cosmos/cosmos-sdk into jonathan/5448-split-generate-only-offline

jgimeno · 2020-03-18T17:48:12Z

Here is the branch using this changes cosmos/gaia#326

alessio · 2020-03-18T18:18:50Z

FTR @jgimeno and I are testing the changes with gaia

alexanderbez · 2020-03-18T18:36:15Z

Please merge when thorough testing has been performed @alessio.

…m:cosmos/cosmos-sdk into jonathan/5448-split-generate-only-offline

alessio · 2020-03-18T18:50:53Z

Manual testing passed. We're now investigating into the drop of coverage stats.

x/auth/client/cli/broadcast.go

x/auth/client/cli/broadcast_test.go

alessio

Just a minor thing left, otherwise this is good to go

Dismissing review as per #5810 (comment)

jgimeno added 2 commits March 16, 2020 18:13

add flag offline

7213e7a

change new context to take care of offline flag

7f2dfde

jgimeno added 6 commits March 16, 2020 19:54

update cli context

e5e9eb0

update command GetCmdWithdrawAllRewards to take care of offline param

d64832f

delete trash doc created

b1962cd

add offline cli context

6ff0f3a

change condition on buildUnsignedStdTxOffline

be4c08c

add new --offline flag

4754189

jgimeno marked this pull request as ready for review March 16, 2020 22:11

jgimeno requested review from alessio, alexanderbez, fedekunze, hschoenburg and nylira as code owners March 16, 2020 22:11

jgimeno self-assigned this Mar 16, 2020

jgimeno added C:CLI R4R labels Mar 16, 2020

alessio reviewed Mar 16, 2020

View reviewed changes

client/context/context.go Outdated Show resolved Hide resolved

okwme mentioned this pull request Mar 16, 2020

'withdraw-all-rewards' Transaction Creation Error on gaiacli #4870

Closed

4 tasks

alessio suggested changes Mar 16, 2020

View reviewed changes

tac0turtle changed the title ~~Jonathan/5448 split generate only offline~~ client: split generate only offline Mar 17, 2020

jgimeno changed the title ~~client: split generate only offline~~ Implementing --offline flag [WIP] Mar 17, 2020

jgimeno added 5 commits March 17, 2020 16:32

implement offline in broadcast command

448f7af

update old offline command to be the generic one

1e6aae6

update code

805dda9

revert removing of parameter

d60146e

add context test with offline

08ccfe5

alessio added WIP and removed R4R labels Mar 17, 2020

jgimeno reopened this Mar 18, 2020

alexanderbez previously requested changes Mar 18, 2020

View reviewed changes

jgimeno and others added 4 commits March 18, 2020 17:19

Update client/context/context.go

0621e57

Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>

Update client/flags/flags.go

09d33f1

Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>

Update x/auth/client/cli/broadcast.go

f2c4dbc

Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>

update changelog

4bc294e

alessio reviewed Mar 18, 2020

View reviewed changes

client/context/context.go Outdated Show resolved Hide resolved

jgimeno added 3 commits March 18, 2020 18:31

update use case when generate only is provided and cannot acces keybase

fff39dc

Merge branch 'jonathan/5448-split-generate-only-offline' of github.co…

9a53f67

…m:cosmos/cosmos-sdk into jonathan/5448-split-generate-only-offline

add flag info message

b73fa03

jgimeno mentioned this pull request Mar 18, 2020

try changes with offline flag cosmos/gaia#326

Merged

11 tasks

jgimeno requested review from alessio and alexanderbez March 18, 2020 17:48

Merge branch 'master' into jonathan/5448-split-generate-only-offline

d24af49

jgimeno added 2 commits March 18, 2020 19:42

add better error message when no node is set

9166dba

Merge branch 'jonathan/5448-split-generate-only-offline' of github.co…

3b4a5e2

…m:cosmos/cosmos-sdk into jonathan/5448-split-generate-only-offline

alessio reviewed Mar 18, 2020

View reviewed changes

x/auth/client/cli/broadcast.go Show resolved Hide resolved

jgimeno added 2 commits March 18, 2020 19:55

fix unit test

0607a27

test broadcast

9df8a94

alessio reviewed Mar 19, 2020

View reviewed changes

x/auth/client/cli/broadcast_test.go Outdated Show resolved Hide resolved

change filepath join

30e07cd

alessio approved these changes Mar 19, 2020

View reviewed changes

alessio merged commit 8c7bb89 into master Mar 19, 2020

alessio deleted the jonathan/5448-split-generate-only-offline branch March 19, 2020 01:49

alessio changed the title ~~Implementing --offline flag~~ implement --offline flag Nov 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement --offline flag #5810

implement --offline flag #5810

jgimeno commented Mar 16, 2020 •

edited

Loading

codecov bot commented Mar 16, 2020 •

edited

Loading

alessio left a comment

alexanderbez left a comment

jgimeno commented Mar 18, 2020

alessio commented Mar 18, 2020

alexanderbez commented Mar 18, 2020

alessio commented Mar 18, 2020

alessio left a comment

implement --offline flag #5810

implement --offline flag #5810

Conversation

jgimeno commented Mar 16, 2020 • edited Loading

Description

codecov bot commented Mar 16, 2020 • edited Loading

Codecov Report

alessio left a comment

Choose a reason for hiding this comment

alexanderbez left a comment

Choose a reason for hiding this comment

jgimeno commented Mar 18, 2020

alessio commented Mar 18, 2020

alexanderbez commented Mar 18, 2020

alessio commented Mar 18, 2020

alessio left a comment

Choose a reason for hiding this comment

jgimeno commented Mar 16, 2020 •

edited

Loading

codecov bot commented Mar 16, 2020 •

edited

Loading