Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try changes with offline flag #326

Merged
merged 11 commits into from
Apr 9, 2020
Merged

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Mar 18, 2020

Closes: #cosmos/cosmos-sdk#5810

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #326 into master will increase coverage by 0.39%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   67.65%   68.05%   +0.39%     
==========================================
  Files           4        4              
  Lines         504      504              
==========================================
+ Hits          341      343       +2     
+ Misses        132      130       -2     
  Partials       31       31
Impacted Files Coverage Δ
lcd_test/helpers.go 76% <100%> (+0.72%) ⬆️

@jgimeno jgimeno marked this pull request as ready for review March 19, 2020 13:30
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACKd (pending tests)

@alessio alessio requested a review from tac0turtle March 19, 2020 14:54
@jgimeno jgimeno requested a review from alessio March 20, 2020 19:54
@jgimeno jgimeno added the R4R label Mar 20, 2020
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgimeno it'd be great if you could add some cli_tests

@jgimeno jgimeno requested a review from alessio March 22, 2020 21:26
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - pending changelog entry

@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #326 into master will increase coverage by 0.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   67.65%   68.05%   +0.39%     
==========================================
  Files           4        4              
  Lines         504      504              
==========================================
+ Hits          341      343       +2     
+ Misses        132      130       -2     
  Partials       31       31              

@jgimeno jgimeno mentioned this pull request Mar 24, 2020
11 tasks
@alessio alessio merged commit 2bff973 into master Apr 9, 2020
@alessio alessio deleted the jonathan/update-to-include-sdk-5810-2 branch April 9, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants