-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try changes with offline flag #326
Conversation
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
==========================================
+ Coverage 67.65% 68.05% +0.39%
==========================================
Files 4 4
Lines 504 504
==========================================
+ Hits 341 343 +2
+ Misses 132 130 -2
Partials 31 31
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACKd (pending tests)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgimeno it'd be great if you could add some cli_tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - pending changelog entry
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
==========================================
+ Coverage 67.65% 68.05% +0.39%
==========================================
Files 4 4
Lines 504 504
==========================================
+ Hits 341 343 +2
+ Misses 132 130 -2
Partials 31 31 |
Closes: #cosmos/cosmos-sdk#5810
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)