Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SDK version #334

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Bump SDK version #334

merged 2 commits into from
Mar 24, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Mar 24, 2020


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez marked this pull request as ready for review March 24, 2020 16:16
@alexanderbez alexanderbez added R4R and removed WIP labels Mar 24, 2020
@alexanderbez alexanderbez self-assigned this Mar 24, 2020
@jgimeno
Copy link
Contributor

jgimeno commented Mar 24, 2020

Looks good! This one maybe is equivalent #326

@alexanderbez
Copy link
Contributor Author

Looks good! This one maybe is equivalent #326

Is that pointing to a commit on master? If so, this supersedes that.

@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #334 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #334   +/-   ##
=======================================
  Coverage   67.65%   67.65%           
=======================================
  Files           4        4           
  Lines         504      504           
=======================================
  Hits          341      341           
  Misses        132      132           
  Partials       31       31
Impacted Files Coverage Δ
lcd_test/helpers.go 75.27% <100%> (ø) ⬆️

@alexanderbez alexanderbez merged commit a8db50e into master Mar 24, 2020
@alexanderbez alexanderbez deleted the bez/bump-sdk-commit branch March 24, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants