Update rustc and cargo commands to use envvars.
#808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emilgardis
requested changes
Jun 16, 2022
Alexhuszagh
force-pushed
the
cargo_command
branch
from
3a33c09
to
0cccc74
Compare
Emilgardis
reviewed
Jun 16, 2022
|
r=me when commit message fixed |
Alexhuszagh
force-pushed
the
cargo_command
branch
from
0cccc74
to
eff6eb3
Compare
|
bors r=Emilgardis |
|
👎 Rejected by code reviews |
|
Merge conflict. |
`rustc` and `cargo` will now use `RUSTC` and `CARGO` environment variables, respectively, if present.
Alexhuszagh
force-pushed
the
cargo_command
branch
from
eff6eb3
to
3afbe9d
Compare
|
bors r=Emilgardis |
bors bot
added a commit
that referenced
this pull request
Jun 16, 2022
808: Update `rustc` and `cargo` commands to use envvars. r=Emilgardis a=Alexhuszagh `rustc` and `cargo` will now use `RUSTC` and `CARGO` environment variables, respectively, if present. 810: fix typo in readme for dockerfile building r=Alexhuszagh a=Emilgardis resolves #809 Co-authored-by: Alex Huszagh <ahuszagh@gmail.com> Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
This was referenced Jun 26, 2022
Alexhuszagh
added a commit
to Alexhuszagh/cross
that referenced
this pull request
Jun 26, 2022
Provides behavior consistent with `cargo` itself, which also ignores it. Closes cross-rs#864. Supersedes cross-rs#865. Partially reverts cross-rs#808.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustcandcargowill now useRUSTCandCARGOenvironment variables, respectively, if present.