Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos in readme #810

Merged
merged 1 commit into from
Jun 16, 2022
Merged

fix typos in readme #810

merged 1 commit into from
Jun 16, 2022

Conversation

Emilgardis
Copy link
Member

@Emilgardis Emilgardis commented Jun 16, 2022 •
edited
Loading

resolves #809

@Emilgardis Emilgardis requested a review from a team as a code owner June 16, 2022 18:59
Emilgardis
Emilgardis commented Jun 16, 2022
View reviewed changes
Copy link
Member Author

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Jun 16, 2022
@bors @Emilgardis
Merge #810
d0f8867 
810: fix typo in readme for dockerfile building r=Emilgardis a=Emilgardis

resolved #809

Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
@Alexhuszagh Alexhuszagh added docs-problem no changelog A valid PR without changelog (no-changelog) labels Jun 16, 2022
@Alexhuszagh
Copy link
Contributor

bors r-
bors r+

@bors
Copy link
Contributor

bors bot commented Jun 16, 2022

Canceled.

bors bot added a commit that referenced this pull request Jun 16, 2022
@bors @Alexhuszagh @Emilgardis
Merge #808 #810
e59d9ab 
808: Update `rustc` and `cargo` commands to use envvars. r=Emilgardis a=Alexhuszagh

`rustc` and `cargo` will now use `RUSTC` and `CARGO` environment variables, respectively, if present.

810: fix typo in readme for dockerfile building r=Alexhuszagh a=Emilgardis

resolves #809

Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>
Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
@Emilgardis
Copy link
Member Author

bors r-

@bors
Copy link
Contributor

bors bot commented Jun 16, 2022

Canceled.

@Emilgardis Emilgardis changed the title fix typo in readme for dockerfile building fix typo in readme Jun 16, 2022
@Emilgardis
Copy link
Member Author

bors r+

@Emilgardis Emilgardis changed the title fix typo in readme fix typos in readme Jun 16, 2022
@bors
Copy link
Contributor

bors bot commented Jun 16, 2022

Build succeeded:

@bors bors bot merged commit 204d123 into cross-rs:main Jun 16, 2022
@Emilgardis Emilgardis deleted the issue809 branch June 16, 2022 19:50
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexhuszagh Alexhuszagh Alexhuszagh approved these changes

Assignees
No one assigned
Labels
docs-problem no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.

README Dockerfile section is wrong
2 participants
@Emilgardis @Alexhuszagh