Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataset ownership test #8583

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Dataset ownership test #8583

merged 2 commits into from
Aug 9, 2023

Conversation

kkorchak
Copy link
Collaborator

@kkorchak kkorchak commented Aug 7, 2023

Dataset ownership test steps:

  1. Create test group and test user(add user to a group)
  2. Open dataset page add and remove user ownership(test every type)
  3. Open dataset page add and remove group owner(test every type)

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the smoke_test Contains changes related to smoke tests label Aug 7, 2023
jjoyce0510
jjoyce0510 reviewed Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking great. Few comments but otherwise LGTM!

jjoyce0510
jjoyce0510 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for refactoring.

@anshbansal anshbansal merged commit 104f0f8 into datahub-project:master Aug 9, 2023
31 checks passed
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
@kkorchak @yoonhyejin
test(ownership): dataset ownership test (#8583)
9e0fdd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
smoke_test Contains changes related to smoke tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkorchak @jjoyce0510 @anshbansal