Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataset ownership test #8583

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Dataset ownership test #8583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3bbcb6
Dataset ownership test
kkorchak Aug 7, 2023
8e94f79
added cypress commands for creating new user, group and add group member
kkorchak Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions smoke-test/tests/cypress/cypress/e2e/mutations/dataset_ownership.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
const test_id = Math.floor(Math.random() * 100000);
const username = `Example Name ${test_id}`;
kkorchak marked this conversation as resolved.
Show resolved Hide resolved
const email = `example${test_id}@example.com`;
const password = "Example password";
const group_name = `Test group ${test_id}`;

const addOwner = (owner, type, elementId) => {
kkorchak marked this conversation as resolved.
Show resolved Hide resolved
cy.clickOptionWithText("Add Owners");
cy.contains("Search for users or groups...").click({ force: true });
cy.focused().type(owner);
cy.clickOptionWithText(owner);
cy.focused().blur();
cy.waitTextVisible(owner);
cy.get('[role="dialog"]').contains("Technical Owner").click();
cy.get('[role="listbox"]').parent().contains(type).click();
cy.get('[role="dialog"]').contains(type).should("be.visible");
cy.clickOptionWithText("Done");
cy.waitTextVisible("Owners Added");
cy.waitTextVisible(type);
cy.waitTextVisible(owner).wait(3000);
cy.clickOptionWithText(owner);
cy.waitTextVisible("SampleCypressHiveDataset");
cy.goToDataset("urn:li:dataset:(urn:li:dataPlatform:hive,SampleCypressHiveDataset,PROD)", "SampleCypressHiveDataset");
cy.get(elementId).next().click();
cy.clickOptionWithText("Yes");
cy.waitTextVisible("Owner Removed");
cy.ensureTextNotPresent(owner);
cy.ensureTextNotPresent(type);
}

describe("add, remove ownership for dataset", () => {
it("create test user and test group, add user to a group", () => {
cy.loginWithCredentials();
cy.createUser(username, password, email);
cy.createGroup(group_name, "Test group description", test_id);
cy.addGroupMember(group_name, `/group/urn:li:corpGroup:${test_id}/assets`, username);
});

it("open test dataset page, add and remove user ownership(test every type)", () => {
cy.loginWithCredentials();
cy.goToDataset("urn:li:dataset:(urn:li:dataPlatform:hive,SampleCypressHiveDataset,PROD)", "SampleCypressHiveDataset");
//business owner
addOwner(username, "Business Owner", `[href="/user/urn:li:corpuser:example${test_id}@example.com"]`);
kkorchak marked this conversation as resolved.
Show resolved Hide resolved
//data steward
addOwner(username, "Data Steward", `[href="/user/urn:li:corpuser:example${test_id}@example.com"]`);
//none
addOwner(username, "None", `[href="/user/urn:li:corpuser:example${test_id}@example.com"]`);
//technical owner
addOwner(username, "Technical Owner", `[href="/user/urn:li:corpuser:example${test_id}@example.com"]`);
});

it("open test dataset page, add and remove group ownership(test every type)", () => {
cy.loginWithCredentials();
cy.goToDataset("urn:li:dataset:(urn:li:dataPlatform:hive,SampleCypressHiveDataset,PROD)", "SampleCypressHiveDataset");
//business owner
addOwner(group_name, "Business Owner", `[href="/group/urn:li:corpGroup:${test_id}"]`);
//data steward
addOwner(group_name, "Data Steward", `[href="/group/urn:li:corpGroup:${test_id}"]`);
//none
addOwner(group_name, "None", `[href="/group/urn:li:corpGroup:${test_id}"]`);
//technical owner
addOwner(group_name, "Technical Owner", `[href="/group/urn:li:corpGroup:${test_id}"]`);
});
});
53 changes: 53 additions & 0 deletions smoke-test/tests/cypress/cypress/support/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,59 @@ Cypress.Commands.add("mouseover", (selector) => {
);
})

Cypress.Commands.add("createUser", (name, password, email) => {
cy.visit("/settings/identities/users");
cy.clickOptionWithText("Invite Users");
cy.waitTextVisible(/signup\?invite_token=\w{32}/).then(($elem) => {
const inviteLink = $elem.text();
cy.visit("/settings/identities/users");
cy.logout();
cy.visit(inviteLink);
cy.enterTextInTestId("email", email);
cy.enterTextInTestId("name", name);
cy.enterTextInTestId("password", password);
cy.enterTextInTestId("confirmPassword", password);
cy.mouseover("#title").click();
cy.waitTextVisible("Other").click();
cy.get("[type=submit]").click();
cy.waitTextVisible("Welcome to DataHub");
cy.hideOnboardingTour();
cy.waitTextVisible(name);
cy.logout()
cy.loginWithCredentials();
})
})

Cypress.Commands.add("createGroup", (name, description, group_id) => {
cy.visit("/settings/identities/groups")
cy.clickOptionWithText("Create group");
cy.waitTextVisible("Create new group");
cy.get("#name").type(name);
cy.get("#description").type(description);
cy.contains("Advanced").click();
cy.waitTextVisible("Group Id");
cy.get("#groupId").type(group_id);
cy.get("#createGroupButton").click();
cy.waitTextVisible("Created group!");
cy.waitTextVisible(name);
})

Cypress.Commands.add("addGroupMember", (group_name, group_urn, member_name) => {
cy.visit(group_urn)
cy.clickOptionWithText(group_name);
cy.contains(group_name).should("be.visible");
cy.get('[role="tab"]').contains("Members").click();
cy.clickOptionWithText("Add Member");
cy.contains("Search for users...").click({ force: true });
cy.focused().type(member_name);
cy.contains(member_name).click();
cy.focused().blur();
cy.contains(member_name).should("have.length", 1);
cy.get('[role="dialog"] button').contains("Add").click({ force: true });
cy.waitTextVisible("Group members added!");
cy.contains(member_name, {timeout: 10000}).should("be.visible");
})

//
//
// -- This is a child command --
Expand Down
Loading