feat(cli/datacontract): Add data quality assertion support #8968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
hsheth2
approved these changes
Oct 11, 2023
| @@ -54,7 +54,7 @@ class DataContract(ConfigModel): | |||
| freshness: Optional[FreshnessAssertion] = pydantic.Field(default=None) | |||
|
|
|||
| # TODO: Add a validator to ensure that ids are unique | |||
| data_quality: Optional[List[DataQualityAssertion]] = None | |||
| data_quality: Optional[List[DataQualityAssertion]] = pydantic.Field(default=None) | |||
There was a problem hiding this comment.
interesting - these two are equivalent right?
| UpstreamClass, | ||
| UpstreamLineageClass, | ||
| ) | ||
| from datahub.specific.dataset import DatasetPatchBuilder |
There was a problem hiding this comment.
looks like the base commit isn't set correct?
|
@asikowitz btw we should probably write some tests for the contracts cli |
|
What exactly is this contracts CLI going to be used for? Can we provide some examples? Also, we are moving quickly on new assertion types, how should we think about adding new types of assertions into contracts? |
jjoyce0510
reviewed
Oct 12, 2023
| @@ -4,6 +4,8 @@ | |||
| from typing_extensions import Literal | |||
|
|
|||
| import datahub.emitter.mce_builder as builder | |||
| from datahub.api.entities.datacontract.assertion import BaseAssertion | |||
There was a problem hiding this comment.
Should we also support Volume Assertions + Freshness Assertions?
Or are these already supported
There was a problem hiding this comment.
Freshness is supported I believe, or at least a subset of it. Volume not yet
maggiehays
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist